Index: media/filters/gpu_video_accelerator_factories.h |
diff --git a/media/filters/gpu_video_accelerator_factories.h b/media/filters/gpu_video_accelerator_factories.h |
index c152c2a4bda8ca51d0769ac047a85bb27e4ce2b3..be635cad7848fa5b657d572505b3dc5da523ea7d 100644 |
--- a/media/filters/gpu_video_accelerator_factories.h |
+++ b/media/filters/gpu_video_accelerator_factories.h |
@@ -21,6 +21,12 @@ namespace media { |
// Helper interface for specifying factories needed to instantiate a hardware |
// video accelerator. |
+// Threading model: |
+// * The GpuVideoAcceleratorFactories may be constructed on any thread. |
+// * The GpuVideoAcceleratorFactories has an associated message loop, which may |
+// be retrieved as |GetMessageLoop()|. |
+// * All calls to the Factories after construction must be made on its message |
+// loop. |
class MEDIA_EXPORT GpuVideoAcceleratorFactories |
: public base::RefCountedThreadSafe<GpuVideoAcceleratorFactories> { |
public: |
@@ -52,16 +58,11 @@ class MEDIA_EXPORT GpuVideoAcceleratorFactories |
// Close()ing the returned pointer. |
virtual base::SharedMemory* CreateSharedMemory(size_t size) = 0; |
- // Returns the message loop the video accelerator runs on. |
+ // Returns the message loop the GpuVideoAcceleratorFactories runs on. Calls |
+ // to interface functions must be made on this loop, with the exception of |
+ // |ReadPixels()|. |
wuchengli
2013/10/24 03:17:20
Remove ReadPixels exception.
sheu
2013/10/25 00:59:30
Done.
|
virtual scoped_refptr<base::MessageLoopProxy> GetMessageLoop() = 0; |
wuchengli
2013/10/24 03:17:20
You probably missed the previous comment. rtc_vide
sheu
2013/10/25 00:59:30
Done.
|
- // Abort any outstanding factory operations and error any future |
- // attempts at factory operations |
- virtual void Abort() = 0; |
- |
- // Returns true if Abort() has been called. |
- virtual bool IsAborted() = 0; |
- |
protected: |
friend class base::RefCountedThreadSafe<GpuVideoAcceleratorFactories>; |
virtual ~GpuVideoAcceleratorFactories(); |