Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: media/base/bind_to_loop.h

Issue 27420004: Remove threading from RendererGpuVideoAcceleratorFactories (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dthread
Patch Set: 282a294f Rebase, rework, Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/bind_to_loop.h
diff --git a/media/base/bind_to_loop.h b/media/base/bind_to_loop.h
index 92d358c7be9432ce6cc5f5b105816b1bf92b2414..b07717cecd3f87ba959d2ee38a289af4fc6a5ebb 100644
--- a/media/base/bind_to_loop.h
+++ b/media/base/bind_to_loop.h
@@ -13,6 +13,7 @@
#include "base/bind.h"
#include "base/location.h"
#include "base/message_loop/message_loop_proxy.h"
+#include "base/synchronization/waitable_event.h"
// This is a helper utility for base::Bind()ing callbacks on to particular
// MessageLoops. A typical use is when |a| (of class |A|) wants to hand a
@@ -50,6 +51,10 @@ base::internal::PassedWrapper<ScopedVector<T> > TrampolineForward(
template <typename T> struct TrampolineHelper;
+// Caller helper to call a base::Closure synchronously
+void TrampolineSyncCaller(const base::Closure& closure,
+ base::WaitableEvent* waiter);
+
template <>
struct TrampolineHelper<void()> {
static void Run(
@@ -57,6 +62,18 @@ struct TrampolineHelper<void()> {
const base::Callback<void()>& cb) {
loop->PostTask(FROM_HERE, base::Bind(cb));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void()>& cb) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -67,6 +84,18 @@ struct TrampolineHelper<void(A1)> {
const base::Callback<void(A1)>& cb, A1 a1) {
loop->PostTask(FROM_HERE, base::Bind(cb, internal::TrampolineForward(a1)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1)>& cb, A1 a1) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -78,6 +107,19 @@ struct TrampolineHelper<void(A1, A2)> {
loop->PostTask(FROM_HERE, base::Bind(cb, internal::TrampolineForward(a1),
internal::TrampolineForward(a2)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1, A2)>& cb, A1 a1, A2 a2) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1),
+ internal::TrampolineForward(a2)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -89,6 +131,20 @@ struct TrampolineHelper<void(A1, A2, A3)> {
loop->PostTask(FROM_HERE, base::Bind(cb, internal::TrampolineForward(a1),
internal::TrampolineForward(a2), internal::TrampolineForward(a3)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1, A2, A3)>& cb, A1 a1, A2 a2, A3 a3) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1),
+ internal::TrampolineForward(a2),
+ internal::TrampolineForward(a3)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -102,6 +158,22 @@ struct TrampolineHelper<void(A1, A2, A3, A4)> {
internal::TrampolineForward(a2), internal::TrampolineForward(a3),
internal::TrampolineForward(a4)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1, A2, A3, A4)>& cb, A1 a1, A2 a2, A3 a3,
+ A4 a4) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1),
+ internal::TrampolineForward(a2),
+ internal::TrampolineForward(a3),
+ internal::TrampolineForward(a4)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -115,6 +187,23 @@ struct TrampolineHelper<void(A1, A2, A3, A4, A5)> {
internal::TrampolineForward(a2), internal::TrampolineForward(a3),
internal::TrampolineForward(a4), internal::TrampolineForward(a5)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1, A2, A3, A4, A5)>& cb, A1 a1, A2 a2, A3 a3,
+ A4 a4, A5 a5) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1),
+ internal::TrampolineForward(a2),
+ internal::TrampolineForward(a3),
+ internal::TrampolineForward(a4),
+ internal::TrampolineForward(a5)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -130,6 +219,24 @@ struct TrampolineHelper<void(A1, A2, A3, A4, A5, A6)> {
internal::TrampolineForward(a4), internal::TrampolineForward(a5),
internal::TrampolineForward(a6)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1, A2, A3, A4, A5, A6)>& cb, A1 a1, A2 a2,
+ A3 a3, A4 a4, A5 a5, A6 a6) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1),
+ internal::TrampolineForward(a2),
+ internal::TrampolineForward(a3),
+ internal::TrampolineForward(a4),
+ internal::TrampolineForward(a5),
+ internal::TrampolineForward(a6)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -145,6 +252,25 @@ struct TrampolineHelper<void(A1, A2, A3, A4, A5, A6, A7)> {
internal::TrampolineForward(a4), internal::TrampolineForward(a5),
internal::TrampolineForward(a6), internal::TrampolineForward(a7)));
}
+ static void RunSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<void(A1, A2, A3, A4, A5, A6, A7)>& cb, A1 a1, A2 a2,
+ A3 a3, A4 a4, A5 a5, A6 a6, A7 a7) {
+ base::WaitableEvent waiter(false, false);
+ loop->PostTask(
+ FROM_HERE,
+ base::Bind(
+ &TrampolineSyncCaller,
+ base::Bind(cb, internal::TrampolineForward(a1),
+ internal::TrampolineForward(a2),
+ internal::TrampolineForward(a3),
+ internal::TrampolineForward(a4),
+ internal::TrampolineForward(a5),
+ internal::TrampolineForward(a6),
+ internal::TrampolineForward(a7)),
+ &waiter));
+ waiter.Wait();
+ }
};
@@ -158,6 +284,14 @@ static base::Callback<T> BindToLoop(
}
template<typename T>
+static base::Callback<T> BindToLoopSync(
+ const scoped_refptr<base::MessageLoopProxy>& loop,
+ const base::Callback<T>& cb) {
+ DCHECK(!loop->BelongsToCurrentThread());
+ return base::Bind(&internal::TrampolineHelper<T>::RunSync, loop, cb);
+}
+
+template<typename T>
static base::Callback<T> BindToCurrentLoop(
const base::Callback<T>& cb) {
return BindToLoop(base::MessageLoopProxy::current(), cb);

Powered by Google App Engine
This is Rietveld 408576698