Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 27418004: Fix up a slew of HTML syntax errors in resource files. (Closed)

Created:
7 years, 2 months ago by Ilya Sherman
Modified:
7 years ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, eroman, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, mmenke
Visibility:
Public.

Description

Fix up a slew of HTML syntax errors in resource files. Most of the fixes are simply properly escaping angle brackets. BUG=307759 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -106 lines) Patch
M chrome/browser/resources/chromeos/about_os_credits.html View 76 chunks +103 lines, -103 lines 0 comments Download
M chrome/browser/resources/chromeos/about_sys.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/cros_log_analyzer_view.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/net_internals/cros_log_visualizer_view.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
7 years, 2 months ago (2013-10-15 23:28:07 UTC) #1
Alexei Svitkine (slow)
Are the credits files generated somehow? If so, should we fix the generators to produce ...
7 years, 2 months ago (2013-10-16 01:22:35 UTC) #2
Nikita (slow)
On 2013/10/16 01:22:35, Alexei Svitkine wrote: > Are the credits files generated somehow? If so, ...
7 years, 2 months ago (2013-10-16 11:19:29 UTC) #3
Ilya Sherman
On 2013/10/16 11:19:29, Nikita Kostylev wrote: > On 2013/10/16 01:22:35, Alexei Svitkine wrote: > > ...
7 years, 2 months ago (2013-10-17 05:02:14 UTC) #4
Ilya Sherman
On 2013/10/17 05:02:14, Ilya Sherman wrote: > On 2013/10/16 11:19:29, Nikita Kostylev wrote: > > ...
7 years, 2 months ago (2013-10-17 05:04:06 UTC) #5
Nikita (slow)
According to https://chromium.googlesource.com/chromiumos/chromite/+log/f9b73d37521bbd72432dd4ac1585b19ff2219b59/license-generation/licenses.py Mark Merlin should know how to fix this.
7 years, 2 months ago (2013-10-17 11:54:07 UTC) #6
Ilya Sherman
7 years, 1 month ago (2013-11-06 01:31:47 UTC) #7
On 2013/10/17 11:54:07, Nikita Kostylev wrote:
> According to
>
https://chromium.googlesource.com/chromiumos/chromite/+log/f9b73d37521bbd7243...
> 
> Mark Merlin should know how to fix this.

Alright, I've tried to upload a patch at [
https://chromium-review.googlesource.com/175844 ].  Hopefully I did that
right...

Powered by Google App Engine
This is Rietveld 408576698