Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 27412003: runAsync name change (Closed)

Created:
7 years, 2 months ago by Kathy Walrath
Modified:
7 years, 2 months ago
Reviewers:
sethladd
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

runAsync name change staged at: https://async-dot-dart-lang.appspot.com/articles/event-loop/ I won't push this until the default download has scheduleMicrotask(). R=sethladd@google.com Committed: 8600cb9

Patch Set 1 #

Total comments: 1

Patch Set 2 : full update of text, tests, images; run the right tests #

Patch Set 3 : fix formatting error #

Patch Set 4 : fix formatting error #

Patch Set 5 : add links, update date #

Patch Set 6 : add links to event loop article; add update date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -8838 lines) Patch
M runtests.sh View 1 1 chunk +1 line, -1 line 0 comments Download
M src/diagrams/articles/event-loop/event-loop.graffle/data.plist View 1 51 chunks +148 lines, -6488 lines 0 comments Download
D src/diagrams/articles/event-loop/event-loop.graffle/image2.tiff View 1 Binary file 0 comments Download
A src/diagrams/articles/event-loop/event-loop.graffle/image4.tiff View 1 Binary file 0 comments Download
D src/diagrams/articles/event-loop/example-code.graffle View 1 1 chunk +0 lines, -1164 lines 0 comments Download
D src/diagrams/articles/event-loop/example-loop.graffle View 1 1 chunk +0 lines, -1086 lines 0 comments Download
M src/site/articles/event-loop/images/scheduling-tasks.png View 1 Binary file 0 comments Download
M src/site/articles/event-loop/images/test-annotated.png View 1 Binary file 0 comments Download
M src/site/articles/event-loop/images/test-queue-output.png View 1 Binary file 0 comments Download
M src/site/articles/event-loop/index.markdown View 1 2 3 4 15 chunks +51 lines, -43 lines 0 comments Download
M src/site/articles/futures-and-error-handling/index.markdown View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/site/articles/using-future-based-apis/index.markdown View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
src/tests/site/articles/event-loop/eventloop_test1/bin/eventloop_test1.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/tests/site/articles/event-loop/eventloop_test2/bin/eventloop_test2.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
src/tests/site/code/webui/build.dart View 1 1 chunk +0 lines, -7 lines 0 comments Download
D src/tests/site/code/webui/pubspec.yaml View 1 1 chunk +0 lines, -6 lines 0 comments Download
D src/tests/site/code/webui/web/webui.dart View 1 1 chunk +0 lines, -14 lines 0 comments Download
D src/tests/site/code/webui/web/webui.html View 1 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kathy Walrath
7 years, 2 months ago (2013-10-16 15:32:33 UTC) #1
sethladd
https://chromiumcodereview.appspot.com/27412003/diff/1/src/site/articles/event-loop/index.markdown File src/site/articles/event-loop/index.markdown (right): https://chromiumcodereview.appspot.com/27412003/diff/1/src/site/articles/event-loop/index.markdown#newcode221 src/site/articles/event-loop/index.markdown:221: **runAsync()** is being renamed to **scheduleMicrotask().** this might show ...
7 years, 2 months ago (2013-10-16 15:43:50 UTC) #2
Kathy Walrath
On 2013/10/16 15:43:50, sethladd wrote: > https://chromiumcodereview.appspot.com/27412003/diff/1/src/site/articles/event-loop/index.markdown > File src/site/articles/event-loop/index.markdown (right): > > https://chromiumcodereview.appspot.com/27412003/diff/1/src/site/articles/event-loop/index.markdown#newcode221 > ...
7 years, 2 months ago (2013-10-16 18:31:24 UTC) #3
sethladd
quick note: rendering as **runAsync().** instead of bold inside the note
7 years, 2 months ago (2013-10-16 18:49:46 UTC) #4
Kathy Walrath
On 2013/10/16 18:49:46, sethladd wrote: > quick note: rendering as **runAsync().** instead of bold inside ...
7 years, 2 months ago (2013-10-16 19:54:04 UTC) #5
Kathy Walrath
Seth, could you take another look?
7 years, 2 months ago (2013-10-22 16:42:47 UTC) #6
sethladd
Let's link from Future-based APIs over to event loop article. Otherwise, LGTM
7 years, 2 months ago (2013-10-22 16:51:32 UTC) #7
Kathy Walrath
On 2013/10/22 16:51:32, sethladd wrote: > Let's link from Future-based APIs over to event loop ...
7 years, 2 months ago (2013-10-22 17:26:28 UTC) #8
Kathy Walrath
7 years, 2 months ago (2013-10-22 17:28:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #6 manually as r8600cb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698