Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: webrtc/api/BUILD.gn

Issue 2739863002: Enable GN check for webrtc/{p2p,system_wrappers} (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/BUILD.gn
diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn
index 71e5243f90336e3f614fd1bf42f739a52ac304d2..fdd441a5d5e646471428acd261251f11c8702164 100644
--- a/webrtc/api/BUILD.gn
+++ b/webrtc/api/BUILD.gn
@@ -35,7 +35,9 @@ rtc_source_set("call_api") {
}
rtc_static_library("libjingle_peerconnection_api") {
- check_includes = false # TODO(kjellander): Remove (bugs.webrtc.org/6828)
+ # Cannot have GN check enabled since that would introduce dependency cycles
+ # TODO(kjellander): Remove (bugs.webrtc.org/7504)
+ check_includes = false
cflags = []
sources = [
"datachannel.h",
@@ -82,7 +84,18 @@ rtc_static_library("libjingle_peerconnection_api") {
deps = [
":rtc_stats_api",
+ "..:webrtc_common",
+ "../base:rtc_base",
+ "../base:rtc_base_approved",
+ "audio_codecs:audio_codecs_api",
]
+
+ # This is needed until bugs.webrtc.org/7504 is removed so this target can
+ # properly depend on ../media:rtc_media_base
+ # TODO(kjellander): Remove this dependency.
+ if (is_nacl) {
+ deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
+ }
}
rtc_source_set("ortc_api") {
« no previous file with comments | « .gn ('k') | webrtc/media/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698