DescriptionRevert of [package.proto] add canonical_base_url field. (patchset #5 id:80001 of https://chromiumcodereview.appspot.com/2728303004/ )
Reason for revert:
aand kitchen needs to handle this proto. reverting.
Original issue's description:
> [package.proto] add canonical_base_url field.
>
> Also document the fields in package.proto and re-run protoc.
>
> canonical_base_url will be used when generating new Markdown documentation
> to allow for meaningful hyperlinks. It's also generally a good idea so when
> packages get mirrored, they'll always point to the source of truth.
>
> NOTE: This changes the tag values for the proto definition... however, since
> we've never used the binary form of the package message, it shouldn't be a
> problem. This allows canonical base url to sort above 'deps'. Otherwise it gets
> sorted to the bottom of the file, which is weird.
>
> R=dnj@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org
> BUG=
>
> Review-Url: https://codereview.chromium.org/2728303004
> Committed: https://github.com/luci/recipes-py/commit/22e413ad35481ecd49d232620e7794ce6f544958
TBR=martiniss@chromium.org,dnj@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2739803002
Committed: https://github.com/luci/recipes-py/commit/28c10d465e3161ec3b862b525c5351ffe9343399
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|