Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 2739803002: Revert of [package.proto] add canonical_base_url field. (Closed)

Created:
3 years, 9 months ago by iannucci
Modified:
3 years, 9 months ago
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of [package.proto] add canonical_base_url field. (patchset #5 id:80001 of https://chromiumcodereview.appspot.com/2728303004/ ) Reason for revert: aand kitchen needs to handle this proto. reverting. Original issue's description: > [package.proto] add canonical_base_url field. > > Also document the fields in package.proto and re-run protoc. > > canonical_base_url will be used when generating new Markdown documentation > to allow for meaningful hyperlinks. It's also generally a good idea so when > packages get mirrored, they'll always point to the source of truth. > > NOTE: This changes the tag values for the proto definition... however, since > we've never used the binary form of the package message, it shouldn't be a > problem. This allows canonical base url to sort above 'deps'. Otherwise it gets > sorted to the bottom of the file, which is weird. > > R=dnj@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2728303004 > Committed: https://github.com/luci/recipes-py/commit/22e413ad35481ecd49d232620e7794ce6f544958 TBR=martiniss@chromium.org,dnj@chromium.org,phajdan.jr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2739803002 Committed: https://github.com/luci/recipes-py/commit/28c10d465e3161ec3b862b525c5351ffe9343399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -84 lines) Patch
M infra/config/recipes.cfg View 1 chunk +0 lines, -1 line 0 comments Download
M recipe_engine/arguments_pb2.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_engine/package.proto View 1 chunk +2 lines, -45 lines 0 comments Download
M recipe_engine/package.py View 9 chunks +10 lines, -23 lines 0 comments Download
M recipe_engine/package_pb2.py View 3 chunks +5 lines, -12 lines 0 comments Download
M recipe_engine/result_pb2.py View 1 chunk +1 line, -1 line 0 comments Download
M unittests/package_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
iannucci
Created Revert of [package.proto] add canonical_base_url field.
3 years, 9 months ago (2017-03-08 04:23:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739803002/1
3 years, 9 months ago (2017-03-08 04:23:43 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 04:23:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/28c10d465e3161ec3b862b525c5351ffe93...

Powered by Google App Engine
This is Rietveld 408576698