Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2738393002: [Telemetry] Re-enable ActionRunnerMeasureMemoryTest in reference builds (Closed)

Created:
3 years, 9 months ago by perezju
Modified:
3 years, 2 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Re-enable ActionRunnerMeasureMemoryTest in reference builds Reference builds have been updated as required. TBR=nednguyen@google.com BUG=catapult:#2610

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
perezju
3 years, 9 months ago (2017-03-10 09:56:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2738393002/1
3 years, 9 months ago (2017-03-10 09:57:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/6652)
3 years, 9 months ago (2017-03-10 10:27:16 UTC) #7
perezju
3 years, 3 months ago (2017-09-06 15:21:28 UTC) #19
+primiano

Is there any reason why we would expect these tests to still fail on reference
builds?

They just request a memory dump and check whether the dump is found on the
trace.

They fail when running on Windows stable, now on 60.0.3112.101 according to [1],
with: 'Unable to obtain memory dump'.

[1]:
https://github.com/catapult-project/catapult/blob/master/common/py_utils/py_u...

Powered by Google App Engine
This is Rietveld 408576698