Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: webrtc/pc/test/mockpeerconnectionobservers.h

Issue 2738353003: Rewrite PeerConnection integration tests using better testing practices. (Closed)
Patch Set: Fixing issues caught by trybots. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/peerconnectioninterface_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 21 matching lines...) Expand all
32 called_ = true; 32 called_ = true;
33 result_ = true; 33 result_ = true;
34 desc_.reset(desc); 34 desc_.reset(desc);
35 } 35 }
36 virtual void OnFailure(const std::string& error) { 36 virtual void OnFailure(const std::string& error) {
37 called_ = true; 37 called_ = true;
38 result_ = false; 38 result_ = false;
39 } 39 }
40 bool called() const { return called_; } 40 bool called() const { return called_; }
41 bool result() const { return result_; } 41 bool result() const { return result_; }
42 SessionDescriptionInterface* release_desc() { 42 std::unique_ptr<SessionDescriptionInterface> MoveDescription() {
43 return desc_.release(); 43 return std::move(desc_);
44 } 44 }
45 45
46 private: 46 private:
47 bool called_; 47 bool called_;
48 bool result_; 48 bool result_;
49 std::unique_ptr<SessionDescriptionInterface> desc_; 49 std::unique_ptr<SessionDescriptionInterface> desc_;
50 }; 50 };
51 51
52 class MockSetSessionDescriptionObserver 52 class MockSetSessionDescriptionObserver
53 : public webrtc::SetSessionDescriptionObserver { 53 : public webrtc::SetSessionDescriptionObserver {
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 int bytes_sent; 221 int bytes_sent;
222 int available_receive_bandwidth; 222 int available_receive_bandwidth;
223 std::string dtls_cipher; 223 std::string dtls_cipher;
224 std::string srtp_cipher; 224 std::string srtp_cipher;
225 } stats_; 225 } stats_;
226 }; 226 };
227 227
228 } // namespace webrtc 228 } // namespace webrtc
229 229
230 #endif // WEBRTC_PC_TEST_MOCKPEERCONNECTIONOBSERVERS_H_ 230 #endif // WEBRTC_PC_TEST_MOCKPEERCONNECTIONOBSERVERS_H_
OLDNEW
« no previous file with comments | « webrtc/pc/peerconnectioninterface_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698