Rewrite PeerConnection integration tests using better testing practices.

webrtc/pc/peerconnection.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_PC_PEERCONNECTION_H_
 #define WEBRTC_PC_PEERCONNECTION_H_
 
 #include <string>
 #include <map>
 #include <memory>
 #include <vector>
 
 #include "webrtc/api/peerconnectioninterface.h"
+#include "webrtc/pc/iceserverparsing.h"
 #include "webrtc/pc/peerconnectionfactory.h"
 #include "webrtc/pc/rtcstatscollector.h"
 #include "webrtc/pc/rtpreceiver.h"
 #include "webrtc/pc/rtpsender.h"
 #include "webrtc/pc/statscollector.h"
 #include "webrtc/pc/streamcollection.h"
 #include "webrtc/pc/webrtcsession.h"
 
 namespace webrtc {
 
@@ skipping 16 matching lines @@
 // Will also set defaults if corresponding constraints are not present:
 // recv_audio=true, recv_video=true, bundle_enabled=true.
 // Other fields will be left with existing values.
 //
 // Deprecated. Will be removed once callers that use constraints are gone.
 // TODO(hta): Remove when callers are gone.
 // https://bugs.chromium.org/p/webrtc/issues/detail?id=5617
 bool ParseConstraintsForAnswer(const MediaConstraintsInterface* constraints,
                                cricket::MediaSessionOptions* session_options);
 
-// Parses the URLs for each server in |servers| to build |stun_servers| and
-// |turn_servers|. Can return SYNTAX_ERROR if the URL is malformed, or
-// INVALID_PARAMETER if a TURN server is missing |username| or |password|.
-RTCErrorType ParseIceServers(
-    const PeerConnectionInterface::IceServers& servers,
-    cricket::ServerAddresses* stun_servers,
-    std::vector<cricket::RelayServerConfig>* turn_servers);
-
 // PeerConnection implements the PeerConnectionInterface interface.
 // It uses WebRtcSession to implement the PeerConnection functionality.
 class PeerConnection : public PeerConnectionInterface,
                        public IceObserver,
                        public rtc::MessageHandler,
                        public sigslot::has_slots<> {
  public:
   explicit PeerConnection(PeerConnectionFactory* factory);
 
   bool Initialize(
@@ skipping 373 matching lines @@
       rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>>
       receivers_;
   std::unique_ptr<WebRtcSession> session_;
   std::unique_ptr<StatsCollector> stats_;
   rtc::scoped_refptr<RTCStatsCollector> stats_collector_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_PC_PEERCONNECTION_H_