Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: chrome/browser/ui/webui/options/autofill_options_handler.cc

Issue 273533003: autofill/options: address some nits I had on one of rouslan@'s CLs[1]. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test fixes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/autofill_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/autofill_options_handler.cc b/chrome/browser/ui/webui/options/autofill_options_handler.cc
index 93b235181c49e6eafd1ef38065e29c7cf70a91d8..0f869baf93ebfb3aa3216075097bb56253f64590 100644
--- a/chrome/browser/ui/webui/options/autofill_options_handler.cc
+++ b/chrome/browser/ui/webui/options/autofill_options_handler.cc
@@ -162,16 +162,16 @@ void SetCountryData(const PersonalDataManager& manager,
}
localized_strings->Set("autofillCountrySelectList", country_list.release());
- scoped_ptr<base::ListValue> defaultCountryComponents(new base::ListValue);
- std::string defaultCountryLanguageCode;
+ scoped_ptr<base::ListValue> default_country_components(new base::ListValue);
please use gerrit instead 2014/05/07 05:12:57 Don't code c++ and js at the same time, kids.
+ std::string default_country_language_code;
GetAddressComponents(countries.front()->country_code(),
g_browser_process->GetApplicationLocale(),
- defaultCountryComponents.get(),
- &defaultCountryLanguageCode);
+ default_country_components.get(),
+ &default_country_language_code);
localized_strings->Set("autofillDefaultCountryComponents",
- defaultCountryComponents.release());
+ default_country_components.release());
localized_strings->SetString("autofillDefaultCountryLanguageCode",
- defaultCountryLanguageCode);
+ default_country_language_code);
}
// Get the multi-valued element for |type| and return it in |ListValue| form.

Powered by Google App Engine
This is Rietveld 408576698