Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

Issue 2732573003: Skip paint property update and visual rect update if no geometry change (Closed)
Patch Set: - Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/PaintInvalidationState.h" 5 #include "core/layout/PaintInvalidationState.h"
6 6
7 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
8 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "core/frame/Settings.h" 9 #include "core/frame/Settings.h"
10 #include "core/layout/LayoutInline.h" 10 #include "core/layout/LayoutInline.h"
(...skipping 612 matching lines...) Expand 10 before | Expand all | Expand 10 after
623 LOG(ERROR) << "Fast path visual rect differs from slow path: fast: " 623 LOG(ERROR) << "Fast path visual rect differs from slow path: fast: "
624 << fastPathRect.toString() 624 << fastPathRect.toString()
625 << " vs slow: " << slowPathRect.toString(); 625 << " vs slow: " << slowPathRect.toString();
626 showLayoutTree(&m_currentObject); 626 showLayoutTree(&m_currentObject);
627 627
628 NOTREACHED(); 628 NOTREACHED();
629 } 629 }
630 630
631 #endif // CHECK_FAST_PATH_SLOW_PATH_EQUALITY 631 #endif // CHECK_FAST_PATH_SLOW_PATH_EQUALITY
632 632
633 static const PaintPropertyTreeBuilderContext& dummyTreeBuilderContext() {
634 DEFINE_STATIC_LOCAL(PaintPropertyTreeBuilderContext, dummyContext, ());
635 return dummyContext;
636 }
637
638 static GeometryMapper& dummyGeometryMapper() { 633 static GeometryMapper& dummyGeometryMapper() {
639 DEFINE_STATIC_LOCAL(std::unique_ptr<GeometryMapper>, dummyMapper, 634 DEFINE_STATIC_LOCAL(std::unique_ptr<GeometryMapper>, dummyMapper,
640 (GeometryMapper::create())); 635 (GeometryMapper::create()));
641 return *dummyMapper; 636 return *dummyMapper;
642 } 637 }
643 638
644 PaintInvalidatorContextAdapter::PaintInvalidatorContextAdapter( 639 PaintInvalidatorContextAdapter::PaintInvalidatorContextAdapter(
645 const PaintInvalidationState& paintInvalidationState) 640 const PaintInvalidationState& paintInvalidationState)
646 // The dummy parameters will be never used because the overriding 641 // The dummy parameter will be never used because the overriding
647 // mapLocalRectToVisualRectInBacking() uses PaintInvalidationState. 642 // mapLocalRectToVisualRectInBacking() uses PaintInvalidationState.
648 : PaintInvalidatorContext(dummyTreeBuilderContext(), dummyGeometryMapper()), 643 : PaintInvalidatorContext(nullptr, dummyGeometryMapper()),
649 m_paintInvalidationState(paintInvalidationState) { 644 m_paintInvalidationState(paintInvalidationState) {
650 forcedSubtreeInvalidationFlags = 645 forcedSubtreeInvalidationFlags =
651 paintInvalidationState.m_forcedSubtreeInvalidationFlags; 646 paintInvalidationState.m_forcedSubtreeInvalidationFlags;
652 paintInvalidationContainer = 647 paintInvalidationContainer =
653 &paintInvalidationState.paintInvalidationContainer(); 648 &paintInvalidationState.paintInvalidationContainer();
654 paintingLayer = &paintInvalidationState.paintingLayer(); 649 paintingLayer = &paintInvalidationState.paintingLayer();
655 } 650 }
656 651
657 void PaintInvalidatorContextAdapter::mapLocalRectToVisualRectInBacking( 652 void PaintInvalidatorContextAdapter::mapLocalRectToVisualRectInBacking(
658 const LayoutObject& object, 653 const LayoutObject& object,
659 LayoutRect& rect) const { 654 LayoutRect& rect) const {
660 DCHECK(&object == &m_paintInvalidationState.currentObject()); 655 DCHECK(&object == &m_paintInvalidationState.currentObject());
661 m_paintInvalidationState.mapLocalRectToVisualRectInBacking(rect); 656 m_paintInvalidationState.mapLocalRectToVisualRectInBacking(rect);
662 } 657 }
663 658
664 } // namespace blink 659 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698