Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 27296002: Add app_list_unittests as a test step and tree closer on mac, win, and linux_aura. (Closed)

Created:
7 years, 2 months ago by tapted
Modified:
7 years, 2 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add app_list_unittests as a test step and tree closer on mac, win, and linux_aura. app_list_unittests has been built on all non-linux targets since r178260. It was added as a default build target for linux_aura in r225936. On linux_chromeos (only) it is already a test step in the waterfall builders, a tree closer, and a CQ step for linux_chromeos. This CL adds app_list_unittests as a test step and tree closer on all platforms that build the target, which is now everything but gtk-linux and mobile. BUG=169114, 166730 R=stip@chromium.org, xusydoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229248

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M masters/master.chromium.linux/master_gatekeeper_cfg.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.linux/master_linux_cfg.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M masters/master.chromium.mac/master_gatekeeper_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.mac/master_mac_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.win/master_gatekeeper_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.win/master_win_cfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 1 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Hi Mike, are you a good reviewer for this? Pretty sure this will do what ...
7 years, 2 months ago (2013-10-17 01:49:48 UTC) #1
ghost stip (do not use)
lgtm, make sure to land in sync with https://codereview.chromium.org/26484004/
7 years, 2 months ago (2013-10-17 20:50:00 UTC) #2
Mike Stip (use stip instead)
lgtm
7 years, 2 months ago (2013-10-17 20:50:44 UTC) #3
tapted
Committed patchset #2 manually as r229248 (presubmit successful).
7 years, 2 months ago (2013-10-17 23:22:27 UTC) #4
cmp
7 years, 2 months ago (2013-10-19 03:15:30 UTC) #5
Message was sent while issue was closed.
This CL didn't add app_list_unittests to tryserver.chromium win7_aura.  In
https://codereview.chromium.org/26484004/, the CQ started depending on that, and
now the CQ is backed up waiting for a config to complete that doesn't exist.  I
uploaded https://codereview.chromium.org/29213006 to fix this on the next
tryserver restart over the long-term and will back out
https://codereview.chromium.org/26484004/ to fix this for the short-term.

Powered by Google App Engine
This is Rietveld 408576698