Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2727143004: Add additional PageLoad UKM metrics using new UKM client API. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index a28d38bbedce2574008d4fe3583f063ee1e51961..59df31fd097ce603458ba8be43718b22c56e64ad 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -12,7 +12,12 @@ namespace internal {
// Name constants are exposed here so they can be referenced from tests.
extern const char kUkmPageLoadEventName[];
+extern const char kUkmParseStartName[];
+extern const char kUkmDomContentLoadedName[];
+extern const char kUkmLoadEventName[];
extern const char kUkmFirstContentfulPaintName[];
+extern const char kUkmFirstMeaningfulPaintName[];
+extern const char kUkmForegroundDurationName[];
} // namespace internal
@@ -54,9 +59,11 @@ class UkmPageLoadMetricsObserver
void RecordTimingMetrics(const page_load_metrics::PageLoadTiming& timing);
// Records metrics based on the PageLoadExtraInfo struct, as well as updating
- // the URL.
+ // the URL. |app_background_time| should be set to a timestamp if the app was
+ // backgrounded, otherwise it should be set to a null TimeTicks.
void RecordPageLoadExtraInfoMetrics(
- const page_load_metrics::PageLoadExtraInfo& info);
+ const page_load_metrics::PageLoadExtraInfo& info,
+ base::TimeTicks app_background_time);
// Unique UKM identifier for the page load we are recording metrics for.
const int32_t source_id_;

Powered by Google App Engine
This is Rietveld 408576698