Allow creation of CRWSessionStorage outside of serialisation API.

Allow creation of CRWSessionStorage outside of serialisation API.

For recreating fake session during unit tests, allow creation of
CRWSessionStorage instance outside of the serialization code (this
required supporting null in AddSerializableUserData method).

Fix typos in serializable_user_data_manager_impl.mm, convert the
code to use base::MakeUnique<> and to pass std::unique_ptr<> to
base::SupportsUserData::SetUserData method.

BUG=None

Review-Url: https://codereview.chromium.org/2726713002
Cr-Commit-Position: refs/heads/master@{#454180}
Committed: https://chromium.googlesource.com/chromium/src/+/32a45a277461ac61b4556e773cb3a16d4e213fa9

[sdefresne, 2017-02-28 23:12:10]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-02-28 23:12:24]

sdefresne@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[sdefresne, 2017-02-28 23:12:25]

Please take a look.

[commit-bot: I haz the power, 2017-02-28 23:13:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2017-02-28 23:53:22]

lgtm

[commit-bot: I haz the power, 2017-03-01 00:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 00:07:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[sdefresne, 2017-03-01 01:20:03]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 01:20:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 01:36:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 01:36:01]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-03-02 03:26:52]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-02 03:26:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2726713002/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-02 03:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 04:38:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488425212543550,
"parent_rev": "734113c8b134ef9738d2e2f2287b01fd9e2243bd", "commit_rev":
"32a45a277461ac61b4556e773cb3a16d4e213fa9"}

[commit-bot: I haz the power, 2017-03-02 04:39:17]

Description was changed from

==========
Allow creation of CRWSessionStorage outside of serialisation API.

For recreating fake session during unit tests, allow creation of
CRWSessionStorage instance outside of the serialization code (this
required supporting null in AddSerializableUserData method).

Fix typos in serializable_user_data_manager_impl.mm, convert the
code to use base::MakeUnique<> and to pass std::unique_ptr<> to
base::SupportsUserData::SetUserData method.

BUG=None
==========

to

==========
Allow creation of CRWSessionStorage outside of serialisation API.

For recreating fake session during unit tests, allow creation of
CRWSessionStorage instance outside of the serialization code (this
required supporting null in AddSerializableUserData method).

Fix typos in serializable_user_data_manager_impl.mm, convert the
code to use base::MakeUnique<> and to pass std::unique_ptr<> to
base::SupportsUserData::SetUserData method.

BUG=None

Review-Url: https://codereview.chromium.org/2726713002
Cr-Commit-Position: refs/heads/master@{#454180}
Committed:
https://chromium.googlesource.com/chromium/src/+/32a45a277461ac61b4556e773cb3...
==========

[commit-bot: I haz the power, 2017-03-02 04:39:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/32a45a277461ac61b4556e773cb3...