Source/core/frame/FrameConsole.cpp - Issue 272613002: DevTools: implemented scriptFailedToParse protocol event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameConsole.cpp

Issue 272613002: DevTools: implemented scriptFailedToParse protocol event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/ScriptDebugServer.cpp ('K') | « Source/bindings/v8/ScriptDebugServer.cpp ('k') | Source/core/inspector/ConsoleMessage.h » ('j') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/FrameConsole.cpp

diff --git a/Source/core/frame/FrameConsole.cpp b/Source/core/frame/FrameConsole.cpp

index 93381749abf147dcb54e4f91ad4ac94080ac2e29..5b4d4cda56c7d2b7765b2e569d4f21ccc74fc914 100644

--- a/Source/core/frame/FrameConsole.cpp

+++ b/Source/core/frame/FrameConsole.cpp

@@ -72,12 +72,10 @@ void FrameConsole::addMessage(MessageSource source, MessageLevel level, const St

if (!context)

return;

- String messageURL;

+ String messageURL = url;

if (callStack) {

- messageURL = callStack->at(0).sourceURL();

- InspectorInstrumentation::addMessageToConsole(context, source, LogMessageType, level, message, callStack, requestIdentifier);

+ InspectorInstrumentation::addMessageToConsole(context, source, LogMessageType, level, message, url, lineNumber, columnNumber, callStack, scriptState, requestIdentifier);

} else {

- messageURL = url;

InspectorInstrumentation::addMessageToConsole(context, source, LogMessageType, level, message, url, lineNumber, columnNumber, scriptState, requestIdentifier);

}