content/public/browser/web_contents.h - Issue 272573005: <webview>: Move NewWindow API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/web_contents.h

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename

Patch Set: Cleanup and fix tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/browser_plugin_guest_delegate.h ('K') | « content/public/browser/child_process_security_policy.h ('k') | content/public/browser/web_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/web_contents.h

diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h

index 38830c3a86cbf2a8cfa0ed931e21c698c4238053..d44eb8cba12e9d0ba5f9df5834816b12e5fd7e45 100644

--- a/content/public/browser/web_contents.h

+++ b/content/public/browser/web_contents.h

@@ -94,6 +94,7 @@ class WebContents : public PageNavigator,

SiteInstance* site_instance;

WebContents* opener;

+ bool opener_suppressed;

lazyboy 2014/05/12 23:00:20 Add desc.

Fady Samuel 2014/05/13 18:59:02 Done.

int routing_id;

int main_frame_routing_id;

@@ -194,10 +195,6 @@ class WebContents : public PageNavigator,

// Gets the current RenderViewHost for this tab.

virtual RenderViewHost* GetRenderViewHost() const = 0;

- // Returns the WebContents embedding this WebContents, if any.

- // If this is a top-level WebContents then it returns NULL.

- virtual WebContents* GetEmbedderWebContents() const = 0;

// Gets the instance ID of the current WebContents if it is embedded

// within a BrowserPlugin. The instance ID of a WebContents uniquely

// identifies it within its embedder WebContents.