Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename
Patch Set: Cleanup and fix tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/guest_view/guest_view_base.cc ('K') | « chrome/browser/guest_view/guest_view_manager.cc ('k') | chrome/browser/guest_view/web_view/plugin_permission_helper.cc » ('j') | chrome/browser/guest_view/web_view/web_view_guest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
diff --git a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc b/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
index 2c198e5c70e900fe1bfa1813446738324aba7453..4209c3bdcce2982a92f1ac166e15dec9bfc2b1b9 100644
--- a/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
+++ b/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc
@@ -61,8 +61,7 @@ void JavaScriptDialogHelper::RunJavaScriptDialog(
guestview::kUrl,
base::Value::CreateStringValue(origin_url.spec()));
webview_guest_->RequestPermission(
- static_cast<BrowserPluginPermissionType>(
- WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG),
+ WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG,
request_info,
base::Bind(&JavaScriptDialogHelper::OnPermissionResponse,
base::Unretained(this),
« chrome/browser/guest_view/guest_view_base.cc ('K') | « chrome/browser/guest_view/guest_view_manager.cc ('k') | chrome/browser/guest_view/web_view/plugin_permission_helper.cc » ('j') | chrome/browser/guest_view/web_view/web_view_guest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698