chrome/browser/chrome_content_browser_client.cc - Issue 272573005: <webview>: Move NewWindow API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename

Patch Set: Cleanup and fix tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/web_view_interactive_browsertest.cc ('k') | chrome/browser/devtools/devtools_targets_ui.cc » ('j') | chrome/browser/guest_view/guest_view_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 06b97e7f9bcecdad3efef4f6b4c870917907cd30..640d6fbfd8f06ca32ac7e046a9f2efc564768e02 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -851,8 +851,7 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(

*guest_delegate = GuestViewBase::Create(

guest_web_contents,

extension_id,

- guest->GetViewType(),

- guest->AsWeakPtr());

+ guest->GetViewType());

return;

}

@@ -869,8 +868,7 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(

*guest_delegate =

GuestViewBase::Create(guest_web_contents,

extension_id,

- api_type,

- base::WeakPtr<GuestViewBase>());

+ api_type);

}

void ChromeContentBrowserClient::GuestWebContentsAttached(