Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chrome/browser/guest_view/web_view/web_view_permission_types.h

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename
Patch Set: Merge with ToT Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_permission_types.h
diff --git a/chrome/browser/guest_view/web_view/web_view_permission_types.h b/chrome/browser/guest_view/web_view/web_view_permission_types.h
index 11df5748e8786daced08473635f703559793ca71..aa4d1a113703c1c0e76ed2e5b945007fc5824a75 100644
--- a/chrome/browser/guest_view/web_view/web_view_permission_types.h
+++ b/chrome/browser/guest_view/web_view/web_view_permission_types.h
@@ -5,11 +5,11 @@
#ifndef CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_PERMISSION_TYPES_H_
#define CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_WEB_VIEW_PERMISSION_TYPES_H_
-#include "content/public/common/browser_plugin_permission_type.h"
-
enum WebViewPermissionType {
- WEB_VIEW_PERMISSION_TYPE_DOWNLOAD =
- BROWSER_PLUGIN_PERMISSION_TYPE_CONTENT_END + 1,
+ // Unknown type of permission request.
+ WEB_VIEW_PERMISSION_TYPE_UNKNOWN,
+
+ WEB_VIEW_PERMISSION_TYPE_DOWNLOAD,
WEB_VIEW_PERMISSION_TYPE_GEOLOCATION,
@@ -24,6 +24,12 @@ enum WebViewPermissionType {
// Media access (audio/video) permission request type.
WEB_VIEW_PERMISSION_TYPE_MEDIA,
+ // New window requests.
+ // Note: Even though new windows don't use the permission API, the new window
+ // API is sufficiently similar that it's convenient to consider it a
+ // permission type for code reuse.
+ WEB_VIEW_PERMISSION_TYPE_NEW_WINDOW,
+
WEB_VIEW_PERMISSION_TYPE_POINTER_LOCK
};
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.cc ('k') | content/browser/browser_plugin/browser_plugin_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698