chrome/browser/guest_view/web_view/plugin_permission_helper.cc - Issue 272573005: <webview>: Move NewWindow API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/plugin_permission_helper.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename

Patch Set: Merge with ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/javascript_dialog_helper.cc ('k') | chrome/browser/guest_view/web_view/web_view_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/plugin_permission_helper.cc

diff --git a/chrome/browser/guest_view/web_view/plugin_permission_helper.cc b/chrome/browser/guest_view/web_view/plugin_permission_helper.cc

index 1ff179e1cb5ee1afafc1b93d7fba90745258fba2..bb9441b0dc363af67f0791f68f867770b1000738 100644

--- a/chrome/browser/guest_view/web_view/plugin_permission_helper.cc

+++ b/chrome/browser/guest_view/web_view/plugin_permission_helper.cc

@@ -73,8 +73,8 @@ void PluginPermissionHelper::OnBlockedUnauthorizedPlugin(

base::DictionaryValue info;

info.SetString(std::string(kPluginName), name);

info.SetString(std::string(kPluginIdentifier), identifier);

- webview->RequestPermission(static_cast<BrowserPluginPermissionType>(

- WEB_VIEW_PERMISSION_TYPE_LOAD_PLUGIN),

+ webview->RequestPermission(

+ WEB_VIEW_PERMISSION_TYPE_LOAD_PLUGIN,

info,

base::Bind(&PluginPermissionHelper::OnPermissionResponse,

weak_factory_.GetWeakPtr(),