chrome/browser/guest_view/guest_view_manager.cc - Issue 272573005: <webview>: Move NewWindow API to chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_manager.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename

Patch Set: Merge with ToT Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/web_view/javascript_dialog_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/guest_view_manager.cc

diff --git a/chrome/browser/guest_view/guest_view_manager.cc b/chrome/browser/guest_view/guest_view_manager.cc

index b0b1ef189323177b7e441f1ef040f114fca0d3e6..833123f4be4954d9a877688aa32d7e7293d5daf3 100644

--- a/chrome/browser/guest_view/guest_view_manager.cc

+++ b/chrome/browser/guest_view/guest_view_manager.cc

@@ -178,7 +178,8 @@ bool GuestViewManager::ForEachGuest(WebContents* embedder_web_contents,

guest_web_contents_by_instance_id_.begin();

it != guest_web_contents_by_instance_id_.end(); ++it) {

WebContents* guest = it->second;

- if (embedder_web_contents != guest->GetEmbedderWebContents())

+ GuestViewBase* guest_view = GuestViewBase::FromWebContents(guest);

+ if (embedder_web_contents != guest_view->embedder_web_contents())

continue;

if (callback.Run(guest))

@@ -272,7 +273,7 @@ bool GuestViewManager::CanEmbedderAccessGuest(int embedder_render_process_id,

return false;

return embedder_render_process_id ==

- guest->GetOpener()->GetEmbedderWebContents()->GetRenderProcessHost()->

+ guest->GetOpener()->embedder_web_contents()->GetRenderProcessHost()->

GetID();

}

« no previous file with comments | « chrome/browser/guest_view/guest_view_base.cc ('k') | chrome/browser/guest_view/web_view/javascript_dialog_helper.cc » ('j') | no next file with comments »