Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename
Patch Set: Merge with ToT Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/devtools/devtools_targets_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 05553c8d19f57af60e0abd188641b6cfd02c23f1..10c86804ebb0a9b82d170523f813663b1c6a7c08 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -811,6 +811,7 @@ content::WebContentsViewDelegate*
}
void ChromeContentBrowserClient::GuestWebContentsCreated(
+ int guest_instance_id,
SiteInstance* guest_site_instance,
WebContents* guest_web_contents,
WebContents* opener_web_contents,
@@ -850,10 +851,10 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
// Create a new GuestViewBase of the same type as the opener.
*guest_delegate = GuestViewBase::Create(
+ guest_instance_id,
guest_web_contents,
extension_id,
- guest->GetViewType(),
- guest->AsWeakPtr());
+ guest->GetViewType());
return;
}
@@ -868,10 +869,10 @@ void ChromeContentBrowserClient::GuestWebContentsCreated(
return;
*guest_delegate =
- GuestViewBase::Create(guest_web_contents,
+ GuestViewBase::Create(guest_instance_id,
+ guest_web_contents,
extension_id,
- api_type,
- base::WeakPtr<GuestViewBase>());
+ api_type);
}
void ChromeContentBrowserClient::GuestWebContentsAttached(
« no previous file with comments | « chrome/browser/chrome_content_browser_client.h ('k') | chrome/browser/devtools/devtools_targets_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698