<webview>: Move NewWindow API to chrome

chrome/browser/guest_view/guest_view_base.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 #define CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_
 
 #include <queue>
 
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "content/public/browser/browser_plugin_guest_delegate.h"
 #include "content/public/browser/web_contents.h"
 
-class AdViewGuest;
-class WebViewGuest;
 struct RendererContentSettingRules;
 
 // A GuestViewBase is the base class browser-side API implementation for a
 // <*view> tag. GuestViewBase maintains an association between a guest
 // WebContents and an embedder WebContents. It receives events issued from
 // the guest and relays them to the embedder.
 class GuestViewBase : public content::BrowserPluginGuestDelegate {
  public:
   class Event {
    public:
@@ skipping 13 matching lines @@
   template <typename T>
   T* As() {
     if (IsViewType(T::Type))
       return static_cast<T*>(this);
 
     return NULL;
   }
 
   static GuestViewBase* Create(content::WebContents* guest_web_contents,
                                const std::string& embedder_extension_id,
-                               const std::string& view_type,
-                               const base::WeakPtr<GuestViewBase>& opener);
+                               const std::string& view_type);
 
   static GuestViewBase* FromWebContents(content::WebContents* web_contents);
 
   static GuestViewBase* From(int embedder_process_id, int instance_id);
 
   // For GuestViewBases, we create special guest processes, which host the
   // tag content separately from the main application that embeds the tag.
   // A GuestViewBase can specify both the partition name and whether the storage
   // for that partition should be persisted. Each tag gets a SiteInstance with
   // a specially formatted URL, based on the application it is hosted by and
@@ skipping 21 matching lines @@
 
   content::WebContents* embedder_web_contents() const {
     return embedder_web_contents_;
   }
 
   // Returns the guest WebContents.
   content::WebContents* guest_web_contents() const {
     return guest_web_contents_;
   }
 
+  // Returns the extra parameters associated with this GuestView passed
+  // in from JavaScript.
+  base::DictionaryValue* extra_params() const {
+    return extra_params_.get();
+  }
+
   // Returns whether this guest has an associated embedder.
   bool attached() const { return !!embedder_web_contents_; }
 
   // Returns the instance ID of the <*view> element.
   int view_instance_id() const { return view_instance_id_; }
 
   // Returns the instance ID of the guest WebContents.
   int guest_instance_id() const { return guest_instance_id_; }
 
   // Returns the extension ID of the embedder.
   const std::string& embedder_extension_id() const {
     return embedder_extension_id_;
   }
 
   // Returns whether this GuestView is embedded in an extension/app.
   bool in_extension() const { return !embedder_extension_id_.empty(); }
 
   // Returns the user browser context of the embedder.
   content::BrowserContext* browser_context() const { return browser_context_; }
 
   // Returns the embedder's process ID.
   int embedder_render_process_id() const { return embedder_render_process_id_; }
 
+  GuestViewBase* GetOpener() const {
+    return opener_.get();
+  }
+
+  void SetOpener(GuestViewBase* opener);
+
   // BrowserPluginGuestDelegate implementation.
-  virtual content::WebContents* GetOpener() const OVERRIDE;
-  virtual void SetOpener(content::WebContents* opener) OVERRIDE;
+  virtual void Destroy() OVERRIDE;
+  virtual void RegisterDestructionCallback(
+      const DestructionCallback& callback) OVERRIDE;
 
  protected:
   GuestViewBase(content::WebContents* guest_web_contents,
-                const std::string& embedder_extension_id,
-                const base::WeakPtr<GuestViewBase>& opener);
+                const std::string& embedder_extension_id);
   virtual ~GuestViewBase();
 
   // Dispatches an event |event_name| to the embedder with the |event| fields.
   void DispatchEvent(Event* event);
 
  private:
   void SendQueuedEvents();
 
   content::WebContents* const guest_web_contents_;
   content::WebContents* embedder_web_contents_;
   const std::string embedder_extension_id_;
   int embedder_render_process_id_;
   content::BrowserContext* const browser_context_;
   // |guest_instance_id_| is a profile-wide unique identifier for a guest
   // WebContents.
   const int guest_instance_id_;
   // |view_instance_id_| is an identifier that's unique within a particular
   // embedder RenderViewHost for a particular <*view> instance.
   int view_instance_id_;
 
   // This is a queue of Events that are destined to be sent to the embedder once
   // the guest is attached to a particular embedder.
   std::deque<linked_ptr<Event> > pending_events_;
 
   // The opener guest view.
   base::WeakPtr<GuestViewBase> opener_;
 
+  DestructionCallback destruction_callback_;
+
+  scoped_ptr<base::DictionaryValue> extra_params_;

[lazyboy, 2014/05/12 23:00:20]

A bit of desc + a typical example of what this dictionary may contain.

[Fady Samuel, 2014/05/13 18:59:02]

Done.

+
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<GuestViewBase> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GuestViewBase);
 };
 
 #endif  // CHROME_BROWSER_GUEST_VIEW_GUEST_VIEW_BASE_H_