Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: chrome/browser/guest_view/ad_view/ad_view_guest.cc

Issue 272573005: <webview>: Move NewWindow API to chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@guestview_manager_rename
Patch Set: Cleanup and fix tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/guest_view/ad_view/ad_view_guest.h" 5 #include "chrome/browser/guest_view/ad_view/ad_view_guest.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "chrome/browser/guest_view/ad_view/ad_view_constants.h" 8 #include "chrome/browser/guest_view/ad_view/ad_view_constants.h"
9 #include "chrome/browser/guest_view/guest_view_constants.h" 9 #include "chrome/browser/guest_view/guest_view_constants.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
11 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
12 12
13 using content::WebContents; 13 using content::WebContents;
14 14
15 AdViewGuest::AdViewGuest(WebContents* guest_web_contents, 15 AdViewGuest::AdViewGuest(WebContents* guest_web_contents,
16 const std::string& extension_id) 16 const std::string& extension_id)
17 : GuestView<AdViewGuest>(guest_web_contents, 17 : GuestView<AdViewGuest>(guest_web_contents,
18 extension_id, 18 extension_id),
19 base::WeakPtr<GuestViewBase>()),
20 WebContentsObserver(guest_web_contents) { 19 WebContentsObserver(guest_web_contents) {
21 } 20 }
22 21
23 // static 22 // static
24 const char AdViewGuest::Type[] = "adview"; 23 const char AdViewGuest::Type[] = "adview";
25 24
26 AdViewGuest::~AdViewGuest() { 25 AdViewGuest::~AdViewGuest() {
27 } 26 }
28 27
29 void AdViewGuest::DidCommitProvisionalLoadForFrame( 28 void AdViewGuest::DidCommitProvisionalLoadForFrame(
(...skipping 21 matching lines...) Expand all
51 // Translate the |error_code| into an error string. 50 // Translate the |error_code| into an error string.
52 std::string error_type; 51 std::string error_type;
53 base::RemoveChars(net::ErrorToString(error_code), "net::", &error_type); 52 base::RemoveChars(net::ErrorToString(error_code), "net::", &error_type);
54 53
55 scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue()); 54 scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
56 args->SetBoolean(guestview::kIsTopLevel, is_main_frame); 55 args->SetBoolean(guestview::kIsTopLevel, is_main_frame);
57 args->SetString(guestview::kUrl, validated_url.spec()); 56 args->SetString(guestview::kUrl, validated_url.spec());
58 args->SetString(guestview::kReason, error_type); 57 args->SetString(guestview::kReason, error_type);
59 DispatchEvent(new GuestViewBase::Event(adview::kEventLoadAbort, args.Pass())); 58 DispatchEvent(new GuestViewBase::Event(adview::kEventLoadAbort, args.Pass()));
60 } 59 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698