Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/browser/background_fetch/background_fetch_job_info.h

Issue 2724783002: Make the BackgroundFetchJobController a per-job object (Closed)
Patch Set: ACTUALLY fix the compile error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_job_info.h
diff --git a/content/browser/background_fetch/background_fetch_job_info.h b/content/browser/background_fetch/background_fetch_job_info.h
index aba5bd8fa89a22e4590e3e88890c6b2cc35aede1..06487e1b3f666bc7d63e4ef46a869ada3d7118b6 100644
--- a/content/browser/background_fetch/background_fetch_job_info.h
+++ b/content/browser/background_fetch/background_fetch_job_info.h
@@ -8,7 +8,6 @@
#include <string>
#include <vector>
-#include "base/macros.h"
#include "content/common/content_export.h"
#include "content/common/service_worker/service_worker_types.h"
#include "url/origin.h"
@@ -22,6 +21,10 @@ class CONTENT_EXPORT BackgroundFetchJobInfo {
BackgroundFetchJobInfo(const std::string& tag,
const url::Origin& origin,
int64_t service_worker_registration_id);
+ // TODO(harkness): Remove copy constructor once the final (non-map-based)
+ // state management is in place and make the class DISALLOW_COPY_AND_ASSIGN.
+ BackgroundFetchJobInfo();
+ BackgroundFetchJobInfo(const BackgroundFetchJobInfo& other);
~BackgroundFetchJobInfo();
const std::string& guid() const { return guid_; }
@@ -46,8 +49,6 @@ class CONTENT_EXPORT BackgroundFetchJobInfo {
// size, current download size, total number of files, number of complete
// files, (possibly) data to show the notification, (possibly) list of in
// progress FetchRequests.
-
- DISALLOW_COPY_AND_ASSIGN(BackgroundFetchJobInfo);
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698