Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Issue 2723003010: 📰 Throw when unregistered feature is queried in tests (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Throw when unregistered feature is queried in tests Allows to register features and explicitly specifying if they should be enabled or not, and now throws an exception when the status of an unregistered feature is queried. Syntax changes from @EnableFeatures({"Foo", "Bar"}) to @Features({ @Features.Register("Foo"), @Features.Register(value = "Bar", enabled = true), @Features.Register(value = "Baz", enabled = false)}) BUG=None Review-Url: https://codereview.chromium.org/2723003010 Cr-Commit-Position: refs/heads/master@{#454908} Committed: https://chromium.googlesource.com/chromium/src/+/715f098c8b479c868c9541dab6cb9e33781de43f

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
dgn
PTAL
3 years, 9 months ago (2017-03-03 17:30:29 UTC) #4
Bernhard Bauer
Neat! LGTM.
3 years, 9 months ago (2017-03-03 17:58:31 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2722243002 Patch 60001). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-03 18:00:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723003010/1
3 years, 9 months ago (2017-03-06 18:02:53 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 19:09:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/715f098c8b479c868c9541dab6cb...

Powered by Google App Engine
This is Rietveld 408576698