Remove HRuntimeType implementation

Remove HRuntimeType implementation

Use the legacy RTI format, which should be replaced with something that lets types and tests be cached and amortized.

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/1ae1ec7df4b22238fd61e9e529ad62a498b3199e

[sra1, 2017-02-28 06:41:26]

sra@google.com changed reviewers:
+ efortuna@google.com, johnniwinther@google.com

[sra1, 2017-02-28 06:41:26]

About 60% of this is reviewed by Emily at
https://chromiumcodereview.appspot.com/2711783006/

This is mostly deleting the runtime support, after a little diversion through an
enqueuer bug.

[Johnni Winther, 2017-02-28 14:31:19]

lgtm

[sra1, 2017-02-28 17:33:43]

Description was changed from

==========
Remove HRuntimeType implementation

Use the legacy RTI format, which should be replaced with something that lets
types and tests be cached and amortized.
==========

to

==========
Remove HRuntimeType implementation

Use the legacy RTI format, which should be replaced with something that lets
types and tests be cached and amortized.

R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1ae1ec7df4b22238fd61e9e529ad62a498b3199e
==========

[sra1, 2017-02-28 17:33:44]

Committed patchset #1 (id:1) manually as
1ae1ec7df4b22238fd61e9e529ad62a498b3199e (presubmit successful).

[Emily Fortuna, 2017-02-28 18:31:10]

lgtm

[floitsch, 2017-03-02 13:43:37]

floitsch@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2017-03-02 13:43:39]

DBC.

https://codereview.chromium.org/2722753002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend_helpers.dart (right):

https://codereview.chromium.org/2722753002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_helpers.dart:615: FunctionEntity get
functionTypeTest =>
It feels fishy that the helper is in no impact.
It turns out that others (like `functionTypeCheck`) will call this function
anyway, but that's not immediately obvious.

https://codereview.chromium.org/2722753002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend_impact.dart (right):

https://codereview.chromium.org/2722753002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_impact.dart:506: new
BackendImpact(staticUses: [/*helpers.functionTypeTestMetaHelper*/]);
Please add a comment explaining why the dead code is not removed.

https://codereview.chromium.org/2722753002/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2722753002/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:3375: return functionTypeObject
== null
return functionTypeObject != null && isFunctionSubType(...)

Unfortunately, dart2js doesn't do this for you.