Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2722603005: Add Custom Feeback Flag to about://flags (Closed)

Created:
3 years, 9 months ago by JJ
Modified:
3 years, 9 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Custom Feeback Flag to about://flags To setup for testing both with the testing, accessiblity and security teams the feedback UI needs to be publically acessible. This CL switches the existing flag from a finch flag to a ui flag. BUG=613357 Review-Url: https://codereview.chromium.org/2722603005 Cr-Commit-Position: refs/heads/master@{#454157} Committed: https://chromium.googlesource.com/chromium/src/+/f7bf2371958105cde93c5be7ff1f17755f0a69fe

Patch Set 1 #

Patch Set 2 : Updated histogram values #

Patch Set 3 : Rebase fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
JJ
Good afternoon everyone! I've been requested to move this from a finch flag to an ...
3 years, 9 months ago (2017-02-28 20:17:57 UTC) #4
JJ
holte: When you get the chance can you check histograms.xml? Thanks!
3 years, 9 months ago (2017-02-28 21:41:50 UTC) #8
Steven Holte
lgtm
3 years, 9 months ago (2017-03-01 17:42:56 UTC) #13
gone
lgtm
3 years, 9 months ago (2017-03-01 22:54:44 UTC) #14
nyquist
lgtm
3 years, 9 months ago (2017-03-01 23:05:43 UTC) #15
Ted C
On 2017/03/01 23:05:43, nyquist wrote: > lgtm ooh, ooh, me too! lgtm :-P
3 years, 9 months ago (2017-03-01 23:30:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722603005/20001
3 years, 9 months ago (2017-03-02 00:18:56 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/162980) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-02 00:21:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722603005/40001
3 years, 9 months ago (2017-03-02 00:41:29 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 02:35:41 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f7bf2371958105cde93c5be7ff1f...

Powered by Google App Engine
This is Rietveld 408576698