Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2722553003: [WIP] Test moving stacking context flag update on ComputedStyle (Closed)

Created:
3 years, 9 months ago by alancutter (OOO until 2018)
Modified:
3 years, 9 months ago
Reviewers:
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, trchen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Test moving stacking context flag update on ComputedStyle This patch effectively reverts https://chromium.googlesource.com/chromium/src/+/a46d892723fe86a7f49113c46e3c40c2343724ce with respect to updating a ComputedStyle's isStackingContext status such that it is now computed in StyleAdjuster instead of Element::styleForLayoutObject() and no longer takes into account transform animations on the frame in which they start. This is to test whether any existing tests fail if we lag the flag value by one frame as the test added in the patch (animations/transform-css-animation-squash-crash.html) no longer fails without the patch's effect on when isStackingContext gets calculated. BUG=695125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-28 03:24:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722553003/1
3 years, 9 months ago (2017-02-28 03:24:46 UTC) #2
alancutter (OOO until 2018)
Description was changed from ========== +testStackingContextPants BUG= ========== to ========== [WIP] Test moving stacking context ...
3 years, 9 months ago (2017-02-28 03:35:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-28 04:00:44 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 04:00:45 UTC) #5
Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698