Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2722483005: Change configuration of user prefs to use mojo. (Closed)

Created:
3 years, 9 months ago by Sam McNally
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change configuration of user prefs to use mojo. Previously, the mojo-bridged user prefs was preconfigured via a C++ interface. This CL adds a mojo configuration interface and changes the existing user (remaining behind a flag) to use that interface rather than directly configuring the user prefs pref store. With this CL, the initial connection is still established out of band. BUG=654988

Patch Set 1 : on for testing #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -298 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.cc View 4 chunks +108 lines, -147 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 6 chunks +28 lines, -8 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 11 chunks +34 lines, -20 lines 0 comments Download
M components/sync_preferences/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync_preferences/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/sync_preferences/pref_service_syncable_factory.cc View 2 chunks +6 lines, -1 line 0 comments Download
M components/user_prefs/tracked/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/user_prefs/tracked/mock_validation_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter.h View 3 chunks +7 lines, -17 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter_unittest.cc View 20 chunks +65 lines, -68 lines 0 comments Download
M components/user_prefs/tracked/tracked_preference_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/preferences/public/cpp/user_prefs_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/cpp/user_prefs_impl.cc View 7 chunks +112 lines, -26 lines 0 comments Download
M services/preferences/public/interfaces/preferences.mojom View 2 chunks +57 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2601873002 Patch 780001

Messages

Total messages: 40 (40 generated)
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-28 03:15:49 UTC) #1
Sam McNally
Patchset #2 (id:20001) has been deleted
3 years, 9 months ago (2017-02-28 03:16:45 UTC) #2
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-28 03:17:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/1
3 years, 9 months ago (2017-02-28 03:18:00 UTC) #4
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-28 03:20:23 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/40001
3 years, 9 months ago (2017-02-28 03:20:41 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-28 03:26:58 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/90532) cast_shell_android on ...
3 years, 9 months ago (2017-02-28 03:26:59 UTC) #8
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-01 07:21:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/60001
3 years, 9 months ago (2017-03-01 07:22:14 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-01 08:03:06 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/400048)
3 years, 9 months ago (2017-03-01 08:03:07 UTC) #12
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-02 02:09:06 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/80001
3 years, 9 months ago (2017-03-02 02:10:30 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-02 02:22:32 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/163117) ios-device-xcode-clang on ...
3 years, 9 months ago (2017-03-02 02:22:33 UTC) #16
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-02 02:57:42 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/100001
3 years, 9 months ago (2017-03-02 02:58:48 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-02 04:52:11 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 9 months ago (2017-03-02 04:52:12 UTC) #20
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 02:31:08 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/120001
3 years, 9 months ago (2017-03-06 02:31:21 UTC) #22
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 02:33:09 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/140001
3 years, 9 months ago (2017-03-06 02:33:14 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-06 02:41:44 UTC) #25
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/53986)
3 years, 9 months ago (2017-03-06 02:41:45 UTC) #26
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 02:45:47 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/160001
3 years, 9 months ago (2017-03-06 02:46:03 UTC) #28
Sam McNally
Patchset #9 (id:180001) has been deleted
3 years, 9 months ago (2017-03-06 02:47:28 UTC) #29
Sam McNally
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-06 02:47:51 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2722483005/190001
3 years, 9 months ago (2017-03-06 02:48:10 UTC) #31
Sam McNally
Patchset #7 (id:140001) has been deleted
3 years, 9 months ago (2017-03-06 02:48:14 UTC) #32
Sam McNally
Patchset #6 (id:120001) has been deleted
3 years, 9 months ago (2017-03-06 02:48:15 UTC) #33
Sam McNally
Patchset #5 (id:100001) has been deleted
3 years, 9 months ago (2017-03-06 02:48:17 UTC) #34
Sam McNally
Patchset #4 (id:80001) has been deleted
3 years, 9 months ago (2017-03-06 02:48:19 UTC) #35
Sam McNally
Patchset #3 (id:60001) has been deleted
3 years, 9 months ago (2017-03-06 02:48:21 UTC) #36
Sam McNally
Patchset #2 (id:40001) has been deleted
3 years, 9 months ago (2017-03-06 02:48:22 UTC) #37
Sam McNally
Patchset #1 (id:1) has been deleted
3 years, 9 months ago (2017-03-06 02:48:26 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-06 03:50:55 UTC) #39
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 03:50:56 UTC) #40 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698