cros - Show progress bar in network detailed view when scanning for

ash/common/system/chromeos/network/network_state_list_detailed_view.cc

Index: ash/common/system/chromeos/network/network_state_list_detailed_view.cc
diff --git a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
index 224c07b5e20d9e8a969d32543d46fe2b3b9e0d23..482c071a4af7b5c8fa00dfbce8122e5f5dcc5763 100644
--- a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
+++ b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
@@ -535,6 +535,16 @@ void NetworkStateListDetailedView::UpdateHeaderButtons() {
         NetworkHandler::Get()->network_state_handler()->DefaultNetwork() !=
         nullptr);
   }
+
+  if (list_type_ != LIST_TYPE_VPN) {
+    bool scanning =
+        NetworkHandler::Get()->network_state_handler()->GetScanningByType(

[tdanderson, 2017/03/02 21:10:28]

TrayNetworkStateObserver::DeviceListChanged()

[tdanderson, 2017/03/02 21:11:14]

^ Ignore this comment, sorry.

+            NetworkTypePattern::WiFi());
+    ShowProgress(-1, scanning);
+    info_button_md_->SetTooltipText(l10n_util::GetStringUTF16(
+        scanning ? IDS_ASH_STATUS_TRAY_WIFI_SCANNING_MESSAGE

[tdanderson, 2017/03/02 21:10:28]

Is this really the right thing to do? I think the loader is indication enough
that scanning is in progress, and for a ChromeVox user, hearing "Scanning is in
progress - Button" could be confusing; I think "Network Info - Button" is better
in both cases since it indicates the purpose of the button.

If you end up making this change to the tooltip then I think you should also
make it at the time when |info_button_md_| is instantiated.

[Evan Stade, 2017/03/02 22:16:39]

this is what the pre-md code used to do before we deleted it (without replacing
it with the md version till now).
for the non chromevox user, I don't think it's obvious what is being scanned.
The string is "Searching for Wi-Fi networks...", not "Scanning is in progress".

For chromevox users, depending on their vision, they probably can't even see the
progress bar so they'd have no idea what's going on without this change.
I don't understand this suggestion. Don't we already set TRAY_NETWORK_INFO at
instantiation time?

[tdanderson, 2017/03/03 16:41:18]

I mis-typed. I meant to type "Searching for Wi-Fi networks... - Button" instead
of "Scanning is in progress - Button".

The point I was trying to make is that if a ChromeVox user hears "Searching for
Wi-Fi networks... - Button" when focusing on the network info button, it doesn't
seem particularly clear that this is in fact the network info button, and that
clicking on this button will show me IP address, etc.

However I did not realize this was the pre-MD behavior for the button, so I
would be OK with this.
Yes we do set TRAY_NETWORK_INFO at instantiation time. If however scanning is in
process at instantiation of the button, it should instead have the tooltip
IDS_..._MESSAGE instead, as you are doing here.

+                 : IDS_ASH_STATUS_TRAY_NETWORK_INFO));
+  }
 }
 
 bool NetworkStateListDetailedView::OrderChild(views::View* view, int index) {