Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2721633006: Reland Add MJPEG support to FakeVideoCaptureDevice (Closed)

Created:
3 years, 9 months ago by chfremer
Modified:
3 years, 9 months ago
Reviewers:
emircan, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Add MJPEG support to FakeVideoCaptureDevice This was reverted as suspected to cause some ChromeOS Autotest failures, see crbug.com/696130. Those failures turned out to be very likely caused by something else. The code is the same as in the original CL % rebase to ToT. Original CL description: Add MJPEG support to FakeVideoCaptureDevice Part of a series of CLs for FakeVideoCaptureDevice with the goal of allowing us to expand our test coverage of the video capture pipeline. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL12. BUG=584797 TEST= capture_unittests --gtest_filter="*Video*" [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2721633006 Cr-Commit-Position: refs/heads/master@{#453726} Committed: https://chromium.googlesource.com/chromium/src/+/fe4c57f8d526e1c286d0504f40e5b178cc527e6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -139 lines) Patch
M media/capture/video/fake_video_capture_device.h View 2 chunks +6 lines, -1 line 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 18 chunks +184 lines, -106 lines 0 comments Download
M media/capture/video/fake_video_capture_device_factory.cc View 4 chunks +25 lines, -13 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 8 chunks +36 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
chfremer
PTAL
3 years, 9 months ago (2017-02-28 19:34:55 UTC) #3
mcasas
On 2017/02/28 19:34:55, chfremer wrote: > PTAL Please make this CL look like e.g. https://crrev.com/2690253002/, ...
3 years, 9 months ago (2017-02-28 21:24:50 UTC) #6
emircan
lgtm % what miguel said.
3 years, 9 months ago (2017-02-28 21:48:42 UTC) #9
chfremer
On 2017/02/28 21:24:50, mcasas wrote: > On 2017/02/28 19:34:55, chfremer wrote: > > PTAL > ...
3 years, 9 months ago (2017-02-28 21:54:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2721633006/1
3 years, 9 months ago (2017-02-28 21:55:01 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 22:19:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe4c57f8d526e1c286d0504f40e5...

Powered by Google App Engine
This is Rietveld 408576698