Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/navigation_manager_impl.mm
diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm
index 9eb0475d298bb69cd595b562e1c31c425b928f58..7e254b2a87d7aba7be66221254fd6fc8e0bea6f3 100644
--- a/ios/web/navigation/navigation_manager_impl.mm
+++ b/ios/web/navigation/navigation_manager_impl.mm
@@ -94,21 +94,19 @@ void NavigationManagerImpl::SetSessionController(
[session_controller_ setNavigationManager:this];
}
-void NavigationManagerImpl::InitializeSession(NSString* window_name,
- BOOL opened_by_dom) {
+void NavigationManagerImpl::InitializeSession(BOOL opened_by_dom) {
SetSessionController([[CRWSessionController alloc]
- initWithWindowName:window_name
- openedByDOM:opened_by_dom
- browserState:browser_state_]);
+ initWithBrowserState:browser_state_
+ openedByDOM:opened_by_dom]);
}
void NavigationManagerImpl::ReplaceSessionHistory(
std::vector<std::unique_ptr<web::NavigationItem>> items,
int current_index) {
SetSessionController([[CRWSessionController alloc]
- initWithNavigationItems:std::move(items)
- currentIndex:current_index
- browserState:browser_state_]);
+ initWithBrowserState:browser_state_
+ navigationItems:std::move(items)
+ currentIndex:current_index]);
}
void NavigationManagerImpl::SetFacadeDelegate(
« no previous file with comments | « ios/web/navigation/navigation_manager_impl.h ('k') | ios/web/navigation/navigation_manager_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698