Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: ios/web/navigation/crw_session_controller+private_constructors.h

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/navigation/crw_session_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_controller+private_constructors.h
diff --git a/ios/web/navigation/crw_session_controller+private_constructors.h b/ios/web/navigation/crw_session_controller+private_constructors.h
index 326eb12effd9d8beba7dd0b129d478d44c7900e7..95ffcb2eb98f9152971f5015368dffc403f3efc5 100644
--- a/ios/web/navigation/crw_session_controller+private_constructors.h
+++ b/ios/web/navigation/crw_session_controller+private_constructors.h
@@ -20,17 +20,15 @@ class NavigationItem;
// CRWSessionControllers. Once CRWSessionController has no users outside of
// web/, these methods can go back into session_controller.h. crbug.com/318974
@interface CRWSessionController (PrivateConstructors)
-// Initializes a session controller, supplying a unique textual identifier for
-// the window, or nil.
-- (instancetype)initWithWindowName:(NSString*)windowName
- openedByDOM:(BOOL)openedByDOM
- browserState:(web::BrowserState*)browserState;
+// Initializes a session controller.
+- (instancetype)initWithBrowserState:(web::BrowserState*)browserState
+ openedByDOM:(BOOL)openedByDOM;
// Initializes a session controller, supplying a list of NavigationItem objects
// and the current index in the navigation history.
-- (instancetype)initWithNavigationItems:(web::ScopedNavigationItemList)items
- currentIndex:(NSUInteger)currentIndex
- browserState:(web::BrowserState*)browserState;
+- (instancetype)initWithBrowserState:(web::BrowserState*)browserState
+ navigationItems:(web::ScopedNavigationItemList)items
+ currentIndex:(NSUInteger)currentIndex;
@end
#endif // IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_PRIVATE_CONSTRUCTORS_H_
« no previous file with comments | « ios/web/navigation/crw_session_controller.mm ('k') | ios/web/navigation/crw_session_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698