Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ios/chrome/browser/ui/ntp/google_landing_controller.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/ntp/google_landing_controller.mm
diff --git a/ios/chrome/browser/ui/ntp/google_landing_controller.mm b/ios/chrome/browser/ui/ntp/google_landing_controller.mm
index 02de0627710da47fb5299189b57b4c51cf4e76d0..8927df5502a3b1b987fbaab850735dc8a70a4fc7 100644
--- a/ios/chrome/browser/ui/ntp/google_landing_controller.mm
+++ b/ios/chrome/browser/ui/ntp/google_landing_controller.mm
@@ -1381,7 +1381,6 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
[strongSelf logMostVisitedClick:index tileType:cell.tileType];
[[strongSelf loader] webPageOrderedOpen:url
referrer:web::Referrer()
- windowName:nil
inBackground:YES
appendTo:kCurrentTab];
};
@@ -1401,7 +1400,6 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
[strongSelf logMostVisitedClick:index tileType:cell.tileType];
[[strongSelf loader] webPageOrderedOpen:url
referrer:web::Referrer()
- windowName:nil
inIncognito:YES
inBackground:NO
appendTo:kCurrentTab];
@@ -1467,7 +1465,6 @@ void SearchEngineObserver::OnTemplateURLServiceChanged() {
if (_notification_promo->IsURLPromo()) {
[_loader webPageOrderedOpen:_notification_promo->url()
referrer:web::Referrer()
- windowName:nil
inBackground:NO
appendTo:kCurrentTab];
_notification_promo.reset();

Powered by Google App Engine
This is Rietveld 408576698