Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: ios/chrome/browser/ui/commands/open_url_command.mm

Issue 2720983002: Remove windowName from CRWSessionController. (Closed)
Patch Set: Address comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/commands/open_url_command.mm
diff --git a/ios/chrome/browser/ui/commands/open_url_command.mm b/ios/chrome/browser/ui/commands/open_url_command.mm
index df740d20f8fdaaa6b452dc34a1018b3958a77983..0045fa51962aef056f511adf2ec0d6cde09cfc62 100644
--- a/ios/chrome/browser/ui/commands/open_url_command.mm
+++ b/ios/chrome/browser/ui/commands/open_url_command.mm
@@ -22,7 +22,6 @@
@synthesize inBackground = _inBackground;
@synthesize fromChrome = _fromChrome;
@synthesize appendTo = _appendTo;
-@synthesize windowName = _windowName;
- (instancetype)initWithTag:(NSInteger)tag {
NOTREACHED();
@@ -31,14 +30,12 @@
- (instancetype)initWithURL:(const GURL&)url
referrer:(const web::Referrer&)referrer
- windowName:(NSString*)windowName
inIncognito:(BOOL)inIncognito
inBackground:(BOOL)inBackground
appendTo:(OpenPosition)appendTo {
if ((self = [super initWithTag:IDC_OPEN_URL])) {
_url = url;
_referrer = referrer;
- _windowName = [windowName copy];
_inIncognito = inIncognito;
_inBackground = inBackground;
_appendTo = appendTo;
@@ -49,7 +46,6 @@
- (instancetype)initWithURLFromChrome:(const GURL&)url {
if ((self = [self initWithURL:url
referrer:web::Referrer()
- windowName:nil
inIncognito:NO
inBackground:NO
appendTo:kLastTab])) {
« no previous file with comments | « ios/chrome/browser/ui/commands/open_url_command.h ('k') | ios/chrome/browser/ui/history/history_collection_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698