|
|
DescriptionAdd a deprecation message to rtcpMuxPolicy of negotiate.
When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set
to be "negotiate", the deprecation message will be return to the console.
If this is approved, the change will be merged to M57.
BUG=chromium:685727
Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo
Review-Url: https://codereview.chromium.org/2720763004
Cr-Commit-Position: refs/heads/master@{#453771}
Committed: https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554bd56566dec0dc
Patch Set 1 #Patch Set 2 : Rebaseling the Layout tests #
Messages
Total messages: 31 (22 generated)
Description was changed from ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. BUG=685727 ========== to ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=685727 ==========
zhihuang@chromium.org changed reviewers: + dcheng@chromium.org, foolip@chromium.org
Hi, Please take a look. Thanks!
Description was changed from ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=685727 ========== to ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 ==========
lgtm
lgtm
The CQ bit was checked by zhihuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by zhihuang@chromium.org
The CQ bit was unchecked by zhihuang@chromium.org
The CQ bit was checked by zhihuang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by zhihuang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org, foolip@chromium.org Link to the patchset: https://codereview.chromium.org/2720763004/#ps20001 (title: "Rebaseling the Layout tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by zhihuang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by zhihuang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488325469443670, "parent_rev": "6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc", "commit_rev": "918bb2c91f07a2cce51cea68554bd56566dec0dc"}
Message was sent while issue was closed.
Description was changed from ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 ========== to ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 Review-Url: https://codereview.chromium.org/2720763004 Cr-Commit-Position: refs/heads/master@{#453771} Committed: https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554b...
Message was sent while issue was closed.
Description was changed from ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 Review-Url: https://codereview.chromium.org/2720763004 Cr-Commit-Position: refs/heads/master@{#453771} Committed: https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554b... ========== to ========== Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo Review-Url: https://codereview.chromium.org/2720763004 Cr-Commit-Position: refs/heads/master@{#453771} Committed: https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554b... ========== |