Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 2720763004: Add a deprecation message to rtcpMuxPolicy of negotiate. (Closed)

Created:
3 years, 9 months ago by zhihuang1
Modified:
3 years, 9 months ago
Reviewers:
dcheng, foolip
CC:
chromium-reviews, blink-reviews, haraken, blink-reviews-frames_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a deprecation message to rtcpMuxPolicy of negotiate. When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set to be "negotiate", the deprecation message will be return to the console. If this is approved, the change will be merged to M57. BUG=chromium:685727 Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo Review-Url: https://codereview.chromium.org/2720763004 Cr-Commit-Position: refs/heads/master@{#453771} Committed: https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554bd56566dec0dc

Patch Set 1 #

Patch Set 2 : Rebaseling the Layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 31 (22 generated)
zhihuang1
Hi, Please take a look. Thanks!
3 years, 9 months ago (2017-02-28 03:24:48 UTC) #3
foolip
lgtm
3 years, 9 months ago (2017-02-28 04:51:36 UTC) #5
dcheng
lgtm
3 years, 9 months ago (2017-02-28 04:52:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720763004/1
3 years, 9 months ago (2017-02-28 18:41:55 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/391336)
3 years, 9 months ago (2017-02-28 20:43:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720763004/20001
3 years, 9 months ago (2017-02-28 22:09:57 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/241319)
3 years, 9 months ago (2017-02-28 22:36:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720763004/20001
3 years, 9 months ago (2017-02-28 23:45:16 UTC) #27
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 00:31:21 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/918bb2c91f07a2cce51cea68554b...

Powered by Google App Engine
This is Rietveld 408576698