Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: ios/web/navigation/session_storage_builder.mm

Issue 2720613005: Refactor serialisation of openerId & openerNavigationIndex. (Closed)
Patch Set: Fix CRWSessionController's initializer comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/serializable_user_data_manager_impl.mm ('k') | ios/web/public/crw_session_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/session_storage_builder.mm
diff --git a/ios/web/navigation/session_storage_builder.mm b/ios/web/navigation/session_storage_builder.mm
index e2dcc4327a72245c3bde911313b39048be62c750..ba2ce49e9ccf3b959f3d8efce7c2be1a792cee04 100644
--- a/ios/web/navigation/session_storage_builder.mm
+++ b/ios/web/navigation/session_storage_builder.mm
@@ -22,9 +22,7 @@
// NavigationManagerImpl;
@interface CRWSessionController (ExposedForSerialization)
@property(nonatomic, readwrite, retain) NSString* tabId;
-@property(nonatomic, readwrite, copy) NSString* openerId;
@property(nonatomic, readwrite, getter=isOpenedByDOM) BOOL openedByDOM;
-@property(nonatomic, readwrite, assign) NSInteger openerNavigationIndex;
@property(nonatomic, readwrite, assign) NSInteger previousNavigationIndex;
@property(nonatomic, readwrite, retain)
CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager;
@@ -42,10 +40,7 @@ CRWSessionStorage* SessionStorageBuilder::BuildStorage(
[[CRWSessionStorage alloc] init];
CRWSessionController* session_controller =
navigation_manager->GetSessionController();
- serialized_navigation_manager.openerID = session_controller.openerId;
serialized_navigation_manager.openedByDOM = session_controller.openedByDOM;
- serialized_navigation_manager.openerNavigationIndex =
- session_controller.openerNavigationIndex;
serialized_navigation_manager.windowName = session_controller.windowName;
serialized_navigation_manager.currentNavigationIndex =
session_controller.currentNavigationIndex;
@@ -88,9 +83,7 @@ void SessionStorageBuilder::ExtractSessionState(
[[CRWSessionController alloc] initWithNavigationItems:std::move(items)
currentIndex:current_index
browserState:nullptr]);
- [session_controller setOpenerId:storage.openerID];
[session_controller setOpenedByDOM:storage.openedByDOM];
- [session_controller setOpenerNavigationIndex:storage.openerNavigationIndex];
[session_controller setWindowName:storage.windowName];
[session_controller
setPreviousNavigationIndex:storage.previousNavigationIndex];
« no previous file with comments | « ios/web/navigation/serializable_user_data_manager_impl.mm ('k') | ios/web/public/crw_session_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698