Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: ios/web/navigation/crw_session_storage_unittest.mm

Issue 2720613005: Refactor serialisation of openerId & openerNavigationIndex. (Closed)
Patch Set: Fix CRWSessionController's initializer comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_storage_unittest.mm
diff --git a/ios/web/navigation/crw_session_storage_unittest.mm b/ios/web/navigation/crw_session_storage_unittest.mm
index ffed4aad9c4aac7a78ddc1d963403f1959078a8f..7626ff4c66897630f731afa43f6fd961ad82d16d 100644
--- a/ios/web/navigation/crw_session_storage_unittest.mm
+++ b/ios/web/navigation/crw_session_storage_unittest.mm
@@ -48,9 +48,7 @@ BOOL SessionStoragesAreEqual(CRWSessionStorage* session1,
NSArray* items1 = session1.itemStorages;
NSArray* items2 = session2.itemStorages;
return ItemStorageListsAreEqual(items1, items2) &&
- [session1.openerID isEqual:session2.openerID] &&
session1.openedByDOM == session2.openedByDOM &&
- session1.openerNavigationIndex == session2.openerNavigationIndex &&
[session1.windowName isEqual:session2.windowName] &&
session1.currentNavigationIndex == session2.currentNavigationIndex &&
session1.previousNavigationIndex == session2.previousNavigationIndex &&
@@ -64,9 +62,7 @@ class CRWNSessionStorageTest : public PlatformTest {
CRWNSessionStorageTest()
: session_storage_([[CRWSessionStorage alloc] init]) {
// Set up |session_storage_|.
- [session_storage_ setOpenerID:@"openerID"];
[session_storage_ setOpenedByDOM:YES];
- [session_storage_ setOpenerNavigationIndex:2];
[session_storage_ setWindowName:@"windowName"];
[session_storage_ setCurrentNavigationIndex:4];
[session_storage_ setPreviousNavigationIndex:3];
« no previous file with comments | « ios/web/navigation/crw_session_controller_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698