Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2720133004: Revert "Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:1… (Closed)

Created:
3 years, 9 months ago by aseemgarg
Modified:
3 years, 9 months ago
Reviewers:
binji
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:140001 of https://codereview.chromium.org/2711473002/ )" This reverts commit 2362f869a4675c10890397ab5d9694b4ac13f009. BUG=v8:4614 Review-Url: https://codereview.chromium.org/2720133004 Cr-Commit-Position: refs/heads/master@{#43467} Committed: https://chromium.googlesource.com/v8/v8/+/048a0a13e75a923c1d5e3e4a1887fbe3e6240a2d

Patch Set 1 #

Patch Set 2 : fix msan issue #

Patch Set 3 : Revert "Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:1… #

Patch Set 4 : Revert "Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:1… #

Patch Set 5 : change style #

Patch Set 6 : Revert "Revert of [Atomics] Implement ldaxr/stlxr instructions in ARM64 simulator (patchset #8 id:1… #

Patch Set 7 : fix compile issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -75 lines) Patch
M src/arm64/constants-arm64.h View 1 chunk +8 lines, -1 line 0 comments Download
M src/arm64/simulator-arm64.h View 1 chunk +91 lines, -0 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 7 chunks +283 lines, -1 line 0 comments Download
M test/cctest/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-simulator-arm.cc View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
A + test/cctest/test-simulator-arm64.cc View 1 2 3 4 5 11 chunks +65 lines, -69 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
aseemgarg
3 years, 9 months ago (2017-02-28 01:29:15 UTC) #1
binji
lgtm
3 years, 9 months ago (2017-02-28 02:21:10 UTC) #4
binji
(tested that this fixes the MSAN issues locally on my machine)
3 years, 9 months ago (2017-02-28 02:21:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720133004/100001
3 years, 9 months ago (2017-02-28 02:59:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/17455)
3 years, 9 months ago (2017-02-28 03:04:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720133004/120001
3 years, 9 months ago (2017-02-28 03:05:58 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 03:31:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/048a0a13e75a923c1d5e3e4a1887fbe3e62...

Powered by Google App Engine
This is Rietveld 408576698