Convert TrackedPreferenceValidationDelegate into a mojo interface.

chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/values.h"
 #include "chrome/browser/safe_browsing/incident_reporting/incident.h"
 #include "chrome/browser/safe_browsing/incident_reporting/mock_incident_receiver.h"
 #include "chrome/common/safe_browsing/csd.pb.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::IsNull;
 using ::testing::NiceMock;
 using ::testing::WithArg;
 
+namespace {
+const char kPrefPath[] = "atomic.pref";
+}
+
 // A basic test harness that creates a delegate instance for which it stores all
 // incidents. Tests can push data to the delegate and verify that the test
 // instance was provided with the expected data.
 class PreferenceValidationDelegateTest : public testing::Test {
  protected:
   typedef std::vector<std::unique_ptr<safe_browsing::Incident>> IncidentVector;
 
-  PreferenceValidationDelegateTest()
-      : kPrefPath_("atomic.pref"),
-        null_value_(base::Value::CreateNullValue()) {}
-
   void SetUp() override {
     testing::Test::SetUp();
     invalid_keys_.push_back(std::string("one"));
     invalid_keys_.push_back(std::string("two"));
     external_validation_invalid_keys_.push_back(std::string("three"));
     std::unique_ptr<safe_browsing::MockIncidentReceiver> receiver(
         new NiceMock<safe_browsing::MockIncidentReceiver>());
     ON_CALL(*receiver, DoAddIncidentForProfile(IsNull(), _))
         .WillByDefault(WithArg<1>(TakeIncidentToVector(&incidents_)));
     instance_.reset(new safe_browsing::PreferenceValidationDelegate(
@@ skipping 34 matching lines @@
 
   static void ExpectKeysEquate(
       const std::vector<std::string>& store_keys,
       const google::protobuf::RepeatedPtrField<std::string>& incident_keys) {
     ASSERT_EQ(store_keys.size(), static_cast<size_t>(incident_keys.size()));
     for (int i = 0; i < incident_keys.size(); ++i) {
       EXPECT_EQ(store_keys[i], incident_keys.Get(i));
     }
   }
 
-  const std::string kPrefPath_;
   IncidentVector incidents_;
-  std::unique_ptr<base::Value> null_value_;
-  base::DictionaryValue dict_value_;
   std::vector<std::string> invalid_keys_;
   std::vector<std::string> external_validation_invalid_keys_;
-  std::unique_ptr<TrackedPreferenceValidationDelegate> instance_;
+  std::unique_ptr<prefs::mojom::TrackedPreferenceValidationDelegate> instance_;
 };
 
 // Tests that a NULL value results in an incident with no value.
 TEST_F(PreferenceValidationDelegateTest, NullValue) {
   instance_->OnAtomicPreferenceValidation(
-      kPrefPath_, NULL, PrefHashStoreTransaction::CLEARED,
+      kPrefPath, NULL, PrefHashStoreTransaction::CLEARED,
       PrefHashStoreTransaction::UNSUPPORTED, false /* is_personal */);
   std::unique_ptr<safe_browsing::ClientIncidentReport_IncidentData> incident(
       incidents_.back()->TakePayload());
   EXPECT_FALSE(incident->tracked_preference().has_atomic_value());
   EXPECT_EQ(
       safe_browsing::
           ClientIncidentReport_IncidentData_TrackedPreferenceIncident::CLEARED,
       incident->tracked_preference().value_state());
 }
 
@@ skipping 42 matching lines @@
     }
     return std::unique_ptr<Value>();
   }
 
   base::Value::Type value_type_;
   const char* expected_value_;
 };
 
 TEST_P(PreferenceValidationDelegateValues, Value) {
   instance_->OnAtomicPreferenceValidation(
-      kPrefPath_, MakeValue(value_type_).get(),
-      PrefHashStoreTransaction::CLEARED, PrefHashStoreTransaction::UNSUPPORTED,
-      false /* is_personal */);
+      kPrefPath, MakeValue(value_type_), PrefHashStoreTransaction::CLEARED,
+      PrefHashStoreTransaction::UNSUPPORTED, false /* is_personal */);
   ASSERT_EQ(1U, incidents_.size());
   std::unique_ptr<safe_browsing::ClientIncidentReport_IncidentData> incident(
       incidents_.back()->TakePayload());
   EXPECT_EQ(std::string(expected_value_),
             incident->tracked_preference().atomic_value());
 }
 
 INSTANTIATE_TEST_CASE_P(
     Values,
     PreferenceValidationDelegateValues,
@@ skipping 28 matching lines @@
     value_state_ = std::tr1::get<0>(GetParam());
     external_validation_value_state_ = std::tr1::get<1>(GetParam());
   }
 
   PrefHashStoreTransaction::ValueState value_state_;
   PrefHashStoreTransaction::ValueState external_validation_value_state_;
 };
 
 TEST_P(PreferenceValidationDelegateNoIncident, Atomic) {
   instance_->OnAtomicPreferenceValidation(
-      kPrefPath_, null_value_.get(), value_state_,
+      kPrefPath, base::Value::CreateNullValue(), value_state_,
       external_validation_value_state_, false /* is_personal */);
   EXPECT_EQ(0U, incidents_.size());
 }
 
 TEST_P(PreferenceValidationDelegateNoIncident, Split) {
   instance_->OnSplitPreferenceValidation(
-      kPrefPath_, &dict_value_, invalid_keys_,
-      external_validation_invalid_keys_, value_state_,
+      kPrefPath, invalid_keys_, external_validation_invalid_keys_, value_state_,
       external_validation_value_state_, false /* is_personal */);
   EXPECT_EQ(0U, incidents_.size());
 }
 
 INSTANTIATE_TEST_CASE_P(
     NoIncident,
     PreferenceValidationDelegateNoIncident,
     testing::Combine(
         testing::Values(PrefHashStoreTransaction::UNCHANGED,
                         PrefHashStoreTransaction::SECURE_LEGACY,
@@ skipping 18 matching lines @@
     is_personal_ = std::tr1::get<2>(GetParam());
   }
 
   PrefHashStoreTransaction::ValueState value_state_;
   PrefHashStoreTransaction::ValueState external_validation_value_state_;
   bool is_personal_;
 };
 
 TEST_P(PreferenceValidationDelegateWithIncident, Atomic) {
   instance_->OnAtomicPreferenceValidation(
-      kPrefPath_, null_value_.get(), value_state_,
+      kPrefPath, base::Value::CreateNullValue(), value_state_,
       external_validation_value_state_, is_personal_);
   ASSERT_EQ(1U, incidents_.size());
   std::unique_ptr<safe_browsing::ClientIncidentReport_IncidentData> incident(
       incidents_.back()->TakePayload());
   EXPECT_TRUE(incident->has_tracked_preference());
   const safe_browsing::
       ClientIncidentReport_IncidentData_TrackedPreferenceIncident& tp_incident =
           incident->tracked_preference();
-  EXPECT_EQ(kPrefPath_, tp_incident.path());
+  EXPECT_EQ(kPrefPath, tp_incident.path());
   EXPECT_EQ(0, tp_incident.split_key_size());
   if (!is_personal_) {
     EXPECT_TRUE(tp_incident.has_atomic_value());
     EXPECT_EQ(std::string("null"), tp_incident.atomic_value());
   } else {
     EXPECT_FALSE(tp_incident.has_atomic_value());
   }
   EXPECT_TRUE(tp_incident.has_value_state());
   ExpectValueStatesEquate(value_state_, external_validation_value_state_,
                           tp_incident.value_state());
 }
 
 TEST_P(PreferenceValidationDelegateWithIncident, Split) {
   instance_->OnSplitPreferenceValidation(
-      kPrefPath_, &dict_value_, invalid_keys_,
-      external_validation_invalid_keys_, value_state_,
+      kPrefPath, invalid_keys_, external_validation_invalid_keys_, value_state_,
       external_validation_value_state_, is_personal_);
   ASSERT_EQ(1U, incidents_.size());
   std::unique_ptr<safe_browsing::ClientIncidentReport_IncidentData> incident(
       incidents_.back()->TakePayload());
   EXPECT_TRUE(incident->has_tracked_preference());
   const safe_browsing::
       ClientIncidentReport_IncidentData_TrackedPreferenceIncident& tp_incident =
           incident->tracked_preference();
-  EXPECT_EQ(kPrefPath_, tp_incident.path());
+  EXPECT_EQ(kPrefPath, tp_incident.path());
   EXPECT_FALSE(tp_incident.has_atomic_value());
   if (!is_personal_) {
     if (value_state_ == PrefHashStoreTransaction::CLEARED ||
         value_state_ == PrefHashStoreTransaction::CHANGED ||
         value_state_ == PrefHashStoreTransaction::UNTRUSTED_UNKNOWN_VALUE) {
       ExpectKeysEquate(invalid_keys_, tp_incident.split_key());
     } else {
       ExpectKeysEquate(external_validation_invalid_keys_,
                        tp_incident.split_key());
     }
@@ skipping 31 matching lines @@
 INSTANTIATE_TEST_CASE_P(
     WithIncidentIgnoreBypass,
     PreferenceValidationDelegateWithIncident,
     testing::Combine(
         testing::Values(PrefHashStoreTransaction::CLEARED,
                         PrefHashStoreTransaction::CHANGED,
                         PrefHashStoreTransaction::UNTRUSTED_UNKNOWN_VALUE),
         testing::Values(PrefHashStoreTransaction::CHANGED,
                         PrefHashStoreTransaction::CLEARED),
         testing::Bool()));