Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2718473002: Add Windows-specific WPR archives for YouTube system health stories (Closed)

Created:
3 years, 10 months ago by charliea (OOO until 10-5)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Windows-specific WPR archives for YouTube system health stories Even with a platform-specific recording, this only kind of works. It seems like all videos still stall around 10 seconds into the video. Given that the YouTube team surprised that capturing the net stream of the site and playing it back worked at all, I think this is as good as can be expected for now. BUG=618698 Review-Url: https://codereview.chromium.org/2718473002 Cr-Commit-Position: refs/heads/master@{#452657} Committed: https://chromium.googlesource.com/chromium/src/+/106c52c87b9deeb8be9127466bec935b695369d3

Patch Set 1 #

Total comments: 1

Patch Set 2 : Actually upload the WPRs #

Patch Set 3 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M tools/battor_agent/battor_connection_impl.cc View 1 2 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
charliea (OOO until 10-5)
3 years, 10 months ago (2017-02-23 16:26:01 UTC) #3
nednguyen
lgtm
3 years, 10 months ago (2017-02-23 16:30:05 UTC) #4
rnephew (Reviews Here)
On 2017/02/23 16:30:05, nednguyen wrote: > lgtm non owner lgtm
3 years, 10 months ago (2017-02-23 16:30:21 UTC) #5
rnephew (Reviews Here)
On 2017/02/23 16:30:21, rnephew (Reviews Here) wrote: > On 2017/02/23 16:30:05, nednguyen wrote: > > ...
3 years, 10 months ago (2017-02-23 16:30:37 UTC) #6
rnephew (Reviews Here)
https://codereview.chromium.org/2718473002/diff/1/tools/perf/page_sets/data/system_health_desktop.json File tools/perf/page_sets/data/system_health_desktop.json (right): https://codereview.chromium.org/2718473002/diff/1/tools/perf/page_sets/data/system_health_desktop.json#newcode79 tools/perf/page_sets/data/system_health_desktop.json:79: "win": "system_health_desktop_044.wpr" Sorry for so many separate comments, but ...
3 years, 10 months ago (2017-02-23 16:31:57 UTC) #8
rnephew (Reviews Here)
On 2017/02/23 16:31:57, rnephew (Reviews Here) wrote: > https://codereview.chromium.org/2718473002/diff/1/tools/perf/page_sets/data/system_health_desktop.json > File tools/perf/page_sets/data/system_health_desktop.json (right): > > ...
3 years, 10 months ago (2017-02-23 19:03:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718473002/20001
3 years, 10 months ago (2017-02-23 19:06:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/160883)
3 years, 10 months ago (2017-02-23 20:21:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718473002/20001
3 years, 10 months ago (2017-02-23 22:08:33 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 22:44:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/106c52c87b9deeb8be9127466bec...

Powered by Google App Engine
This is Rietveld 408576698