ios/chrome/browser/tabs/tab_unittest.mm - Issue 2718273003: Change return type of Tab -navigationManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2718273003: Change return type of Tab -navigationManager. (Closed)

Patch Set: Fix BrowserViewControllerTest unit tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab_unittest.mm

diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm

index a873a6571d5ee6fc1d0f853b639acbdf3ae26612..7441cc86e39081cb8d08d72b827b2755a34f3766 100644

--- a/ios/chrome/browser/tabs/tab_unittest.mm

+++ b/ios/chrome/browser/tabs/tab_unittest.mm

@@ -234,12 +234,12 @@ class TabTest : public BlockCleanupTest {

transition:ui::PAGE_TRANSITION_CLIENT_REDIRECT];

web::Referrer empty_referrer;

- [tab_ navigationManager]->AddPendingItem(

+ [tab_ navigationManagerImpl]->AddPendingItem(

redirectUrl, empty_referrer, ui::PAGE_TRANSITION_CLIENT_REDIRECT,

web::NavigationInitiationType::RENDERER_INITIATED);

web_state_impl_->OnProvisionalNavigationStarted(redirectUrl);

- [[tab_ navigationManager]->GetSessionController() commitPendingItem];

+ [[tab_ navigationManagerImpl]->GetSessionController() commitPendingItem];

[[tab_ webController] webStateImpl]->OnNavigationCommitted(redirectUrl);

[tab_ webDidStartLoadingURL:redirectUrl shouldUpdateHistory:YES];