Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2718273003: Change return type of Tab -navigationManager. (Closed)
Patch Set: Fix BrowserViewControllerTest unit tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index 3ae0cf90422e148070ada5ed78c914bdd030a0af..d116d4df79a710428213894050db9dd112c060a4 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -578,7 +578,7 @@ TEST_F(TabModelTest, AddWithOrderControllerAndGrouping) {
Tab* parent = [tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer];
// Force the history to update, as it is used to determine grouping.
ASSERT_TRUE([parent navigationManager]);
- [[parent navigationManager]->GetSessionController() commitPendingItem];
+ [[parent navigationManagerImpl]->GetSessionController() commitPendingItem];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer];
@@ -614,7 +614,7 @@ TEST_F(TabModelTest, AddWithOrderControllerAndGrouping) {
parent_params.transition_type = ui::PAGE_TRANSITION_TYPED;
[[parent webController] loadWithParams:parent_params];
ASSERT_TRUE([parent navigationManager]);
- [[parent navigationManager]->GetSessionController() commitPendingItem];
+ [[parent navigationManagerImpl]->GetSessionController() commitPendingItem];
EXPECT_EQ([tab_model_ indexOfTab:parent], 0U);
// Add a new tab. It should be added behind the parent. It should not be added
@@ -655,7 +655,7 @@ TEST_F(TabModelTest, AddWithLinkTransitionAndIndex) {
Tab* parent = [tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer];
// Force the history to update, as it is used to determine grouping.
ASSERT_TRUE([parent navigationManager]);
- [[parent navigationManager]->GetSessionController() commitPendingItem];
+ [[parent navigationManagerImpl]->GetSessionController() commitPendingItem];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer];
[tab_model_ addTabWithURL:kURL referrer:kEmptyReferrer];
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/chrome/browser/tabs/tab_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698