Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: ios/chrome/browser/tabs/tab_model.mm

Issue 2718273003: Change return type of Tab -navigationManager. (Closed)
Patch Set: Fix BrowserViewControllerTest unit tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_model_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model.mm
diff --git a/ios/chrome/browser/tabs/tab_model.mm b/ios/chrome/browser/tabs/tab_model.mm
index 91d1237e03bf0983f64f1ba8c4978c0f6c0ac565..b173d1fc5b0c206152092b89b86e6e2744cc956f 100644
--- a/ios/chrome/browser/tabs/tab_model.mm
+++ b/ios/chrome/browser/tabs/tab_model.mm
@@ -740,7 +740,7 @@ Tab* GetOpenerForTab(id<NSFastEnumeration> tabs, Tab* tab) {
_browserState
? IOSChromeTabRestoreServiceFactory::GetForBrowserState(_browserState)
: nullptr;
- web::NavigationManagerImpl* navigationManager = [closedTab navigationManager];
+ web::NavigationManager* navigationManager = [closedTab navigationManager];
DCHECK(navigationManager);
int itemCount = navigationManager->GetItemCount();
if (restoreService && (![self isNTPTab:closedTab] || itemCount > 1)) {
@@ -787,7 +787,7 @@ Tab* GetOpenerForTab(id<NSFastEnumeration> tabs, Tab* tab) {
// See if the navigation was within a page; if so ignore it.
web::NavigationItem* previousItem =
- [tab navigationManager]->GetPreviousItem();
+ [tab navigationManagerImpl]->GetPreviousItem();
if (previousItem) {
GURL previousURL = previousItem->GetURL();
GURL currentURL = [tab navigationManager]->GetVisibleItem()->GetURL();
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_model_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698