Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: ios/chrome/browser/tabs/tab.h

Issue 2718273003: Change return type of Tab -navigationManager. (Closed)
Patch Set: Fix BrowserViewControllerTest unit tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.h
diff --git a/ios/chrome/browser/tabs/tab.h b/ios/chrome/browser/tabs/tab.h
index eb88fc6f64f4b2b9f5333a226bac2301d3044c3c..5115735515c7be0d7399bdbe028f05f93380e6ab 100644
--- a/ios/chrome/browser/tabs/tab.h
+++ b/ios/chrome/browser/tabs/tab.h
@@ -57,6 +57,7 @@ struct SessionTab;
namespace web {
class NavigationItem;
+class NavigationManager;
class NavigationManagerImpl;
struct Referrer;
class WebState;
@@ -244,7 +245,10 @@ extern NSString* const kProxyPassthroughHeaderValue;
// Returns the NavigationManager for this tab's WebState. Requires WebState to
// be populated. Can return null.
-- (web::NavigationManagerImpl*)navigationManager;
+// TODO(crbug.com/620465): remove navigationManagerImpl once Tab no longer uses
+// nor exposes private ios/web/ API.
+- (web::NavigationManager*)navigationManager;
+- (web::NavigationManagerImpl*)navigationManagerImpl;
// Update the tab's history by replacing all previous navigations with
// |navigations|.
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698