Fix PendingScript::errorOccurred() to be consistent with getSource()

Fix PendingScript::errorOccurred() to be consistent with getSource()

Previously, PendingScript::errorOccurred() didn't take |m_integrityFailure|
into consideration while getSource()'s |errorOccurred| did.

This CL merges these two implementations and thus makes
PendingScript::errorOccurred() to take |m_integrityFailure| into consideration.

BUG=686281
Review-Url: https://codereview.chromium.org/2716543002
Cr-Commit-Position: refs/heads/master@{#452518}
Committed: https://chromium.googlesource.com/chromium/src/+/ac80ac8e76ab5e54af045fe844ebbef4c7e1c325

[hiroshige, 2017-02-23 01:59:03]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:59:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-23 02:04:18]

hiroshige@chromium.org changed reviewers:
+ kouhei@chromium.org, sigbjornf@opera.com

[hiroshige, 2017-02-23 02:04:19]

PTAL (if bots are happy).

It looks trivial to
- remove getSource()'s |errorOccurred| parameter and
- replacing it with errorOccurred() call,
but I intentionally didn't do that, because, to make the code to align the spec,
it would be better (harder though):
- make getSource() to return null-ish thing when errorOccurred, and remove
|errorOccurred| parameter from getSource(), and
- remove errorOccurred() and merging it into getSource()

[commit-bot: I haz the power, 2017-02-23 03:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:34:14]

Dry run: This issue passed the CQ dry run.

[sof, 2017-02-23 08:10:48]

lgtm, i'm not convinced (yet) that changing getSource()'s signature adds real
value here.

https://codereview.chromium.org/2716543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/PendingScript.cpp (right):

https://codereview.chromium.org/2716543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/PendingScript.cpp:259: return
resource()->errorOccurred() || m_integrityFailure;
The ScriptLoader will consult the resource to decide if an error occurred upon
getting this finished notification - do you plan to update it to use this
predicate instead?

[hiroshige, 2017-02-23 16:41:25]

https://codereview.chromium.org/2716543002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/PendingScript.cpp (right):

https://codereview.chromium.org/2716543002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/PendingScript.cpp:259: return
resource()->errorOccurred() || m_integrityFailure;
On 2017/02/23 08:10:48, sof wrote:
> The ScriptLoader will consult the resource to decide if an error occurred upon
> getting this finished notification - do you plan to update it to use this
> predicate instead?

Oh, this line? I'll update it soon.
https://codesearch.chromium.org/chromium/src/third_party/WebKit/Source/core/d...

(I'm preparing for module support and trying to reduce direct references to
ScriptResource/ScriptSourceCode/etc. via PendingScript.)

[hiroshige, 2017-02-23 16:41:48]

Description was changed from

==========
Fix PendingScript::errorOccurred() to be consistent with getSource()

Previously, PendingScript::errorOccurred() didn't take |m_integrityFailure|
into consideration while getSource()'s |errorOccurred| did.

This CL merges these two implementations and thus makes
PendingScript::errorOccurred() to take |m_integrityFailure| into consideration.

BUG=
==========

to

==========
Fix PendingScript::errorOccurred() to be consistent with getSource()

Previously, PendingScript::errorOccurred() didn't take |m_integrityFailure|
into consideration while getSource()'s |errorOccurred| did.

This CL merges these two implementations and thus makes
PendingScript::errorOccurred() to take |m_integrityFailure| into consideration.

BUG=686281
==========

[hiroshige, 2017-02-23 16:41:57]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2017-02-23 16:42:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 16:47:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487868117929430, "parent_rev":
"d95453989b7c14ae3c9012d04be75f3ffc012d48", "commit_rev":
"ac80ac8e76ab5e54af045fe844ebbef4c7e1c325"}

[commit-bot: I haz the power, 2017-02-23 16:48:15]

Description was changed from

==========
Fix PendingScript::errorOccurred() to be consistent with getSource()

Previously, PendingScript::errorOccurred() didn't take |m_integrityFailure|
into consideration while getSource()'s |errorOccurred| did.

This CL merges these two implementations and thus makes
PendingScript::errorOccurred() to take |m_integrityFailure| into consideration.

BUG=686281
==========

to

==========
Fix PendingScript::errorOccurred() to be consistent with getSource()

Previously, PendingScript::errorOccurred() didn't take |m_integrityFailure|
into consideration while getSource()'s |errorOccurred| did.

This CL merges these two implementations and thus makes
PendingScript::errorOccurred() to take |m_integrityFailure| into consideration.

BUG=686281

Review-Url: https://codereview.chromium.org/2716543002
Cr-Commit-Position: refs/heads/master@{#452518}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac80ac8e76ab5e54af045fe844eb...
==========

[commit-bot: I haz the power, 2017-02-23 16:48:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac80ac8e76ab5e54af045fe844eb...