Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2715513004: [net] Remove unnecessary virtual specifier (Closed)

Created:
3 years, 10 months ago by asanka
Modified:
3 years, 10 months ago
Reviewers:
Bence, shivanisha
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net] Remove unnecessary virtual specifier BUG=none Review-Url: https://codereview.chromium.org/2715513004 Cr-Commit-Position: refs/heads/master@{#452512} Committed: https://chromium.googlesource.com/chromium/src/+/5e8286c3350c0b8d4352f713f4495abcfb4ff1cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M net/http/http_auth_controller.h View 1 chunk +16 lines, -17 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
asanka
3 years, 10 months ago (2017-02-22 20:31:44 UTC) #6
shivanisha
On 2017/02/22 at 20:31:44, asanka wrote: > lgtm
3 years, 10 months ago (2017-02-22 20:53:54 UTC) #7
asanka
On 2017/02/22 20:53:54, shivanisha wrote: > On 2017/02/22 at 20:31:44, asanka wrote: > > > ...
3 years, 10 months ago (2017-02-22 20:56:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715513004/1
3 years, 10 months ago (2017-02-22 20:57:09 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-22 20:57:10 UTC) #12
asanka
On 2017/02/22 20:57:10, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-23 15:37:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715513004/1
3 years, 10 months ago (2017-02-23 15:38:18 UTC) #15
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-23 15:38:20 UTC) #17
asanka
bnc: Can you stampy?
3 years, 10 months ago (2017-02-23 15:56:53 UTC) #21
Bence
On 2017/02/23 15:56:53, asanka wrote: > bnc: Can you stampy? LGTM
3 years, 10 months ago (2017-02-23 16:05:23 UTC) #22
asanka
On 2017/02/23 16:05:23, Bence wrote: > On 2017/02/23 15:56:53, asanka wrote: > > bnc: Can ...
3 years, 10 months ago (2017-02-23 16:05:58 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2715513004/1
3 years, 10 months ago (2017-02-23 16:06:27 UTC) #25
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 16:14:25 UTC) #28
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e8286c3350c0b8d4352f713f449...

Powered by Google App Engine
This is Rietveld 408576698