|
|
Description[net] Remove unnecessary virtual specifier
BUG=none
Review-Url: https://codereview.chromium.org/2715513004
Cr-Commit-Position: refs/heads/master@{#452512}
Committed: https://chromium.googlesource.com/chromium/src/+/5e8286c3350c0b8d4352f713f4495abcfb4ff1cb
Patch Set 1 #
Messages
Total messages: 28 (15 generated)
The CQ bit was checked by asanka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
asanka@chromium.org changed reviewers: + shivanisha@chromium.org
On 2017/02/22 at 20:31:44, asanka wrote: > lgtm
The CQ bit was checked by asanka@chromium.org
On 2017/02/22 20:53:54, shivanisha wrote: > On 2017/02/22 at 20:31:44, asanka wrote: > > > > lgtm Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/02/22 20:57:10, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. Can I lgtm my own CL?
The CQ bit was checked by asanka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Description was changed from ========== [net] Remove unnecessary virtual specifier BUG=none ========== to ========== [net] Remove unnecessary virtual specifier BUG=none ==========
asanka@chromium.org changed reviewers: + jkarlin@chromium.org
asanka@chromium.org changed reviewers: + bnc@chromium.org - jkarlin@chromium.org
bnc: Can you stampy?
On 2017/02/23 15:56:53, asanka wrote: > bnc: Can you stampy? LGTM
On 2017/02/23 16:05:23, Bence wrote: > On 2017/02/23 15:56:53, asanka wrote: > > bnc: Can you stampy? > > LGTM Thanks!
The CQ bit was checked by asanka@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487865962432940, "parent_rev": "fbb1bb97ae95653a5d4cc6b55d3f71260ac5fc5d", "commit_rev": "5e8286c3350c0b8d4352f713f4495abcfb4ff1cb"}
Message was sent while issue was closed.
Description was changed from ========== [net] Remove unnecessary virtual specifier BUG=none ========== to ========== [net] Remove unnecessary virtual specifier BUG=none Review-Url: https://codereview.chromium.org/2715513004 Cr-Commit-Position: refs/heads/master@{#452512} Committed: https://chromium.googlesource.com/chromium/src/+/5e8286c3350c0b8d4352f713f449... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5e8286c3350c0b8d4352f713f449... |