Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: ios/web/navigation/crw_session_controller_unittest.mm

Issue 2712743008: Remove -insertTabWithWebState:atIndex: from TabModel. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/navigation/crw_session_controller_unittest.mm
diff --git a/ios/web/navigation/crw_session_controller_unittest.mm b/ios/web/navigation/crw_session_controller_unittest.mm
index 16d984bf1fd38d62a69c435c54262b969aafd83f..96cb5df650abe1adf63d95430198c607a10a08a3 100644
--- a/ios/web/navigation/crw_session_controller_unittest.mm
+++ b/ios/web/navigation/crw_session_controller_unittest.mm
@@ -688,7 +688,7 @@ std::unique_ptr<web::NavigationItemImpl> CreateNavigationItem(
}
TEST_F(CRWSessionControllerTest, CreateWithEmptyNavigations) {
- std::vector<std::unique_ptr<web::NavigationItem>> items;
+ web::ScopedNavigationItemList items;
base::scoped_nsobject<CRWSessionController> controller(
[[CRWSessionController alloc] initWithBrowserState:&browser_state_
navigationItems:std::move(items)
@@ -700,7 +700,7 @@ TEST_F(CRWSessionControllerTest, CreateWithEmptyNavigations) {
}
TEST_F(CRWSessionControllerTest, CreateWithNavList) {
- std::vector<std::unique_ptr<web::NavigationItem>> items;
+ web::ScopedNavigationItemList items;
items.push_back(CreateNavigationItem("http://www.google.com",
"http://www.referrer.com", @"Google"));
items.push_back(CreateNavigationItem("http://www.yahoo.com",
@@ -762,7 +762,7 @@ TEST_F(CRWSessionControllerTest, PreviousNavigationEntry) {
}
TEST_F(CRWSessionControllerTest, PushNewEntry) {
- std::vector<std::unique_ptr<web::NavigationItem>> items;
+ web::ScopedNavigationItemList items;
items.push_back(CreateNavigationItem("http://www.firstpage.com",
"http://www.starturl.com", @"First"));
items.push_back(CreateNavigationItem("http://www.secondpage.com",
@@ -805,7 +805,7 @@ TEST_F(CRWSessionControllerTest, PushNewEntry) {
}
TEST_F(CRWSessionControllerTest, IsSameDocumentNavigation) {
- std::vector<std::unique_ptr<web::NavigationItem>> items;
+ web::ScopedNavigationItemList items;
items.push_back(
CreateNavigationItem("http://foo.com", "http://google.com", @"First"));
// Push state navigation.
@@ -858,7 +858,7 @@ TEST_F(CRWSessionControllerTest, IsSameDocumentNavigation) {
}
TEST_F(CRWSessionControllerTest, UpdateCurrentEntry) {
- std::vector<std::unique_ptr<web::NavigationItem>> items;
+ web::ScopedNavigationItemList items;
items.push_back(CreateNavigationItem("http://www.firstpage.com",
"http://www.starturl.com", @"First"));
items.push_back(CreateNavigationItem("http://www.secondpage.com",
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/web/navigation/navigation_manager_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698