Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Issue 2712483006: Add histogram to track down errors when initializing the audio client. (Closed)

Created:
3 years, 10 months ago by tommi (sloooow) - chröme
Modified:
3 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram to track down errors when initializing the audio client. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2712483006 Cr-Commit-Position: refs/heads/master@{#452599} Committed: https://chromium.googlesource.com/chromium/src/+/a55e42d9d9805d0ef86b82370ed3fe054f1401bf

Patch Set 1 #

Total comments: 3

Patch Set 2 : Switch HRESULT to Hresult #

Patch Set 3 : Merge Hresult and D3DHresult, update 'HRESULT' use in a few places to use 'enum' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -40 lines) Patch
M media/audio/win/audio_low_latency_input_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 8 chunks +42 lines, -40 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
tommi (sloooow) - chröme
henrika - main reviewer asvitkine - histogram owner
3 years, 10 months ago (2017-02-23 10:48:30 UTC) #3
henrika (OOO until Aug 14)
LGTM https://codereview.chromium.org/2712483006/diff/1/media/audio/win/audio_low_latency_input_win.cc File media/audio/win/audio_low_latency_input_win.cc (right): https://codereview.chromium.org/2712483006/diff/1/media/audio/win/audio_low_latency_input_win.cc#newcode718 media/audio/win/audio_low_latency_input_win.cc:718: UMA_HISTOGRAM_SPARSE_SLOWLY("Media.Audio.Capture.Win.InitError", hr); Just FYI. Mac specific stats are ...
3 years, 10 months ago (2017-02-23 11:20:52 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/2712483006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2712483006/diff/1/tools/metrics/histograms/histograms.xml#newcode24602 tools/metrics/histograms/histograms.xml:24602: +<histogram name="Media.Audio.Capture.Win.InitError" units="HRESULT"> I think we have an enum ...
3 years, 10 months ago (2017-02-23 15:29:49 UTC) #5
tommi (sloooow) - chröme
https://codereview.chromium.org/2712483006/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2712483006/diff/1/tools/metrics/histograms/histograms.xml#newcode24602 tools/metrics/histograms/histograms.xml:24602: +<histogram name="Media.Audio.Capture.Win.InitError" units="HRESULT"> On 2017/02/23 15:29:49, Alexei Svitkine (slow) ...
3 years, 10 months ago (2017-02-23 16:20:56 UTC) #6
Alexei Svitkine (slow)
Yeah, re-using WinGetLastError and expanding it sgtm. On Thu, Feb 23, 2017 at 11:20 AM, ...
3 years, 10 months ago (2017-02-23 16:31:46 UTC) #7
tommi (sloooow) - chröme
On 2017/02/23 16:31:46, Alexei Svitkine (slow) wrote: > Yeah, re-using WinGetLastError and expanding it sgtm. ...
3 years, 10 months ago (2017-02-23 16:34:18 UTC) #8
tommi (sloooow) - chröme
On 2017/02/23 16:34:18, tommi (krómíum) wrote: > On 2017/02/23 16:31:46, Alexei Svitkine (slow) wrote: > ...
3 years, 10 months ago (2017-02-23 16:36:00 UTC) #9
Alexei Svitkine (slow)
Defining a separate HRESULT enum and populating it as we see codes sgtm if it's ...
3 years, 10 months ago (2017-02-23 16:49:09 UTC) #10
tommi (sloooow) - chröme
Switch HRESULT to Hresult
3 years, 10 months ago (2017-02-23 18:04:25 UTC) #11
tommi (sloooow) - chröme
On 2017/02/23 16:49:09, Alexei Svitkine (slow) wrote: > Defining a separate HRESULT enum and populating ...
3 years, 10 months ago (2017-02-23 18:07:48 UTC) #12
Alexei Svitkine (slow)
Do you mind merging the two hresult enums then in this CL? Also, you need ...
3 years, 10 months ago (2017-02-23 18:09:53 UTC) #14
tommi (sloooow) - chröme
Merge Hresult and D3DHresult, update 'HRESULT' use in a few places to use 'enum'
3 years, 10 months ago (2017-02-23 18:18:59 UTC) #16
tommi (sloooow) - chröme
Done On Thu, Feb 23, 2017 at 7:09 PM Alexei Svitkine <asvitkine@chromium.org> wrote: > Do ...
3 years, 10 months ago (2017-02-23 18:19:26 UTC) #17
Alexei Svitkine (slow)
lgtm - thanks for the clean up!
3 years, 10 months ago (2017-02-23 18:21:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712483006/40001
3 years, 10 months ago (2017-02-23 18:23:21 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 20:10:48 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a55e42d9d9805d0ef86b82370ed3...

Powered by Google App Engine
This is Rietveld 408576698